-
-
Notifications
You must be signed in to change notification settings - Fork 167
Adding --validate option __main__ and run new validation #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sounds good to me. This broke the |
Tests are passing now. Not sure exactly what was the goal of mocking modules in the original tests, but I reimplemented all tests in a way that seems simpler to me, and that everything is being tested. I also added calls to I don't think the coverage warning is relevant, I think it's being caused by the lack of tests of the |
@larsoner did you have a chance to look at this? I think this should be ready, let me know if it's not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Deal with --ignore
in a separate PR?
Yes, I think ignoring is complex enough to go into a separate PR. We probably want to specify it in |
Okay let's get this in and keep iterating, thanks @datapythonista |
Closes #213
python -m numpydoc
keeps existing functionality, but when called with--validate
runs the new validation: