Skip to content

Updating minimum sphinx version in setup.py #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 23, 2019

Fixes #210

I'm seeing the getLogger error message in our CI but then in setup.py the fact that it should work with 1.2.3 has sent me into some dead-ends.

    logger = logging.getLogger(__name__)
AttributeError: module 'sphinx.util.logging' has no attribute 'getLogger'

@rgommers
Copy link
Member

Thanks @bsipocz. I just updated it to 1.6.5 to match our CI and have a full version number.

Waiting for a decision on gh-210, then I'll either put this or another fix in and release 0.9.1 later today.

@jnothman jnothman merged commit cbb3dc4 into numpy:master Apr 23, 2019
@jnothman
Copy link
Member

Thanks @bsipocz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'module' object has no attribute 'getLogger'
3 participants