BUG: fix refcount issue caused by #12524 #12573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
added
00 - Bug
component: numpy._core
08 - Backport
|
Test if azure is triggered. |
|
Try again. |
|
Yay, works. Had to explicitly disable YAML overrides for both CI and PR validation triggers on the azure pipeline. |
|
Shippable is missing, though. @tylerjereddy I don't see 1.16.x as a branch on shippable, does it need to be added? All the other maintenance branches are there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12544 .
PR #12524 introduced a refcount issue. Changing the interface to PyUFuncOverride_GetOutObjects so that *out_kwd_obj is never a borrowed reference should fix it.