This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Add more specific integer constructors #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes numpy#72 - Removed SupportsFloat from the classes int8, int16, int32, int64, uint8, uint16, uint32, and uint64 - Removed a test from tests/pass/scalars.py - Added several tests to tests/fail/scalars.py
Updated tests/fail/scalars.py with formatting done by black
person142
reviewed
Apr 29, 2020
| @@ -20,7 +20,6 @@ def __float__(self): | |||
| np.int16(3.4) | |||
| np.int32(4) | |||
| np.int64(-1) | |||
| np.uint8(A()) | |||
There was a problem hiding this comment.
Instead of removing, I would follow what is done here:
https://github.com/numpy/numpy-stubs/pull/70/files#diff-dd377d4c09025262e6f7008bcfe583dfR10
i.e.
class B:
def __int__(self):
return 4
...
np.uint8(B())(That way we keep a case checking that a class with __int__ passes.)
- Added an uint8 test back - Created a new integer class definition - Corrected a float class definition
|
Made the changes you mentioned @person142. Thanks. |
|
Merged, thanks @rajatdiptabiswas. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
SupportsFloatfrom the classesint8,int16,int32,int64,uint8,uint16,uint32, anduint64tests/pass/scalars.pytests/fail/scalars.pyKindly let me know if these look alright.