Skip to content

Refactor PreferenceManager and Preferences #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 30, 2020
Merged

Refactor PreferenceManager and Preferences #269

merged 4 commits into from
Nov 30, 2020

Conversation

seanwu1105
Copy link
Contributor

Refactor PreferenceManager and Preferences with fully covered tests. This new implementation meets the same quality to the one of Data Persistence refactoring (#227) by using async-mutex to make sure each set methods is atomic.

@seanwu1105 seanwu1105 added the code Improvements to code quality or project architecture label Nov 27, 2020
@seanwu1105 seanwu1105 added this to the beta7.1 milestone Nov 27, 2020
@seanwu1105 seanwu1105 requested a review from shc261392 November 27, 2020 17:07
@seanwu1105 seanwu1105 self-assigned this Nov 27, 2020
@seanwu1105 seanwu1105 mentioned this pull request Nov 27, 2020
Closed
@seanwu1105 seanwu1105 marked this pull request as draft November 27, 2020 17:08
@seanwu1105 seanwu1105 marked this pull request as ready for review November 30, 2020 04:02
shc261392
shc261392 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@seanwu1105 seanwu1105 merged commit 09edef1 into develop Nov 30, 2020
@seanwu1105 seanwu1105 deleted the refactor-preference branch November 30, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees

@seanwu1105 seanwu1105

Labels
code Improvements to code quality or project architecture
Projects
None yet
Milestone
beta7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@seanwu1105 @shc261392