Set GOPATH and GOROOT for build package to daemon context #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: Should read STDERR rather than STDOUT. | ||
| out, err := exec.Command("go", "install", p.ImportPath).Output() | ||
| out, err := cmd.CombinedOutput() |
There was a problem hiding this comment.
Doesn't this change invalidate the comment above? It should either be removed if it's considered done, or changed to:
// TODO: Should read STDERR only rather than STDOUT+STDERR combined.
There was a problem hiding this comment.
It's okay to remove that comment, output is redirected to log, the more output we have the better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the
GOPATHandGOROOTare set to the daemon context when building a package.This handles the situation where the daemon is started under one
GOROOTandGOPATHgo env, but receives requests in a differentgo env.