feat: SPIM configuration #64
Conversation
| } else if mode == MODE_2 { | ||
| w.order().msb_first().cpol().active_low().cpha().leading() | ||
| } else { | ||
| w.order().msb_first().cpol().active_low().cpha().trailing() |
There was a problem hiding this comment.
Maybe panic or return Err here if not mode 0..3?
There was a problem hiding this comment.
There are only 4 modes possible (parity and phase are booleans), so if it is not mode 0 through 2, it must be 3, and there are no other possibilities. I agree this is ugly and unclear, adding the Eq derive would mean being able to use a match which would be much nicer.
There was a problem hiding this comment.
I would prefer a match here ;) It's the rusty way to do this :)
There was a problem hiding this comment.
We can't match on the value since it doesn't implement Eq. The next embedded-hal release will fix that, but I'd prefer not to wait for that.
error: to use a constant of type `X` in a pattern, `X` must be annotated with `#[derive(PartialEq, Eq)]`
There was a problem hiding this comment.
Oh, I am very sorry, it's even written down below ... I didn't read on first ... I somehow thought it's an enum.
|
Oops, I forgot to fix the examples |
nrf52-hal-common/src/spim.rs
Outdated
| ); | ||
| // Configure mode | ||
| spim.config.write(|w| { | ||
| // Can't match on `mode` as embedded_hal::spi::Mode only derives PartialEq, not Eq |
There was a problem hiding this comment.
| // Can't match on `mode` as embedded_hal::spi::Mode only derives PartialEq, not Eq | |
| // Can't match on `mode` due to embedded-hal, see https://github.com/rust-embedded/embedded-hal/pull/126 |
|
Looks good to me now. The changes with the embedded-hal can be added once its new version is live. |
This PR allows the configuration of the frequency, mode and over-read character of the SPIM interfaces.