fix: drop node 10 support #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We should wait till npm itself doesn't require node10 to merge this just so we don't put the cart before the horse here. |
Member
|
Let's make the test environments and engines declarations match the npm@8 PR |
wraithgar
force-pushed
the
nlf/remove-node-10
branch
from
ebba2cd to
0d2e430
Compare
This matches the new npm@8 engines field
wraithgar
force-pushed
the
nlf/remove-node-10
branch
from
0d2e430 to
c603675
Compare
lukekarrys
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both removes node 10.0.x and 10.x from the testing matrix, and adds a node engine requirement of
>=12References