fix: command completion #4032
Merged
fix: command completion #4032
+452
−539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
added
Release 8.x
wraithgar
force-pushed
the
gar/completion-fix
branch
4 times, most recently
from
6576f29 to
c0df220
Compare
lukekarrys
approved these changes
Nov 10, 2021
The fake npm object in the tests wasn't returning an async function Fixes: #4020 PR-URL: #4032 Credit: @wraithgar Close: #4032 Reviewed-by: @lukekarrys
wraithgar
force-pushed
the
gar/completion-fix
branch
from
c0df220 to
72ca4a4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake npm object in the tests wasn't returning an async function
Fixes: #4020