Skip to content

Commit 86278c8

Browse files
authored
chore: move undici to known failure for all node versions (#6146)
1 parent cb721c4 commit 86278c8

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

.github/workflows/node-integration.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -282,16 +282,14 @@ jobs:
282282
'uuid', // tests that crypto.getRandomValues throws but it doesn't
283283
'weak', // doesn't seem to build in node >12
284284
'mkdirp', // failing actions in own repo
285+
'undici', // test failure in node >=18, unable to root cause
285286
]
286287
287-
if (NODE_VERSION.startsWith('18.')) {
288+
if (NODE_VERSION === '18') {
288289
knownFailures.push('multer')
289-
} else if (NODE_VERSION.startsWith('19.')) {
290-
// test failure in node >=19, unable to root cause
291-
knownFailures.push('undici')
290+
} else if (NODE_VERSION === '19') {
291+
// empty block
292292
} else if (NODE_VERSION === 'nightly') {
293-
// test failure in node >=19, unable to root cause
294-
knownFailures.push('undici')
295293
// fails in node 20, looks like a streams issue
296294
knownFailures.push('fastify')
297295
// esbuild barfs on node 20.0.0-pre

0 commit comments

Comments
 (0)