Skip to content

Commit 11e3c41

Browse files
committed
chore: skip flaky max listeners test
I feel better about doing this now that it is likely a Node.js bug, and not due to the new @npmcli/agent behavior.
1 parent eacec5f commit 11e3c41

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

smoke-tests/test/max-listeners.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,11 @@ const runTest = async (t, { env } = {}) => {
2222
return npm('install', { stderr: true, env })
2323
}
2424

25-
// https://github.com/npm/cli/issues/6763
26-
t.test('no max listeners', async t => {
25+
// See https://github.com/npm/cli/issues/6763 for initial reason for this test.
26+
// Edit: This test is very flaky in CI and is likely due to a Node.js bug
27+
// (https://github.com/nodejs/node/pull/50136). This test is being skipped for
28+
// now and will be revisited once the Node.js bugfix has landed across 18+.
29+
t.todo('no max listeners', async t => {
2730
// in node 20.4.0 and above (20.6.1 at the time of this test) installs show
2831
// MaxListenersExceeded warnings during some installs. these go away with the
2932
// --no-network-family-autoselection flag. this test documents this behavior

0 commit comments

Comments
 (0)