fixup: set json config in pkg get explicitly

Author: lukekarrys

lib/commands/pkg.js

@@ -56,6 +56,7 @@ class Pkg extends BaseCommand {
   }
 
   async get (args, { path, workspace }) {
+    this.npm.config.set('json', true)
     const pkgJson = await PackageJson.load(path)
 
     let unwrap = false

lib/npm.js

@@ -301,6 +301,7 @@ class Npm {
 
     output.flush({
       [META]: true,
+      json: this.config.get('json'),
       jsonError: jsonError(err, this),
     })
 

lib/utils/display.js

@@ -172,7 +172,8 @@ class Display {
   #command
   #levelIndex
   #timing
-  #json
+  #jsonConfig
+  #jsonOutput
   #heading
   #silent
 
@@ -208,6 +209,11 @@ class Display {
     }
   }
 
+  // We are in json mode if set from the config or if jsonOutput is set via a handler
+  get #json () {
+    return this.#jsonConfig || this.#jsonOutput
+  }
+
   async load ({
     command,
     heading,
@@ -239,7 +245,7 @@ class Display {
     this.#command = command
     this.#levelIndex = LEVEL_OPTIONS[loglevel].index
     this.#timing = timing
-    this.#json = ['pkg'].includes(command) ? true : json
+    this.#jsonConfig = json
     this.#heading = heading
     this.#silent = this.#levelIndex <= 0
 
@@ -290,6 +296,7 @@ class Display {
   // Arrow function assigned to a private class field so it can be passed
   // directly as a listener and still reference "this"
   #outputHandler = withMeta((level, meta, ...args) => {
+    this.#jsonOutput = meta.json
     switch (level) {
       case output.KEYS.flush: {
         this.#outputState.buffering = false

test/lib/commands/pkg.js

@@ -578,7 +578,7 @@ t.test('delete nested field', async t => {
 })
 
 t.test('workspaces', async t => {
-  const { pkg, OUTPUT, readPackageJson } = await mockNpm(t, {
+  const mockWorkspaces = (t) => mockNpm(t, {
     prefixDir: {
       'package.json': JSON.stringify({
         name: 'root',
@@ -605,64 +605,70 @@ t.test('workspaces', async t => {
     config: { workspaces: true },
   })
 
-  await pkg('get', 'name', 'version')
+  t.test('get', async t => {
+    const { pkg, OUTPUT } = await mockWorkspaces(t)
+    await pkg('get', 'name', 'version')
+    t.strictSame(
+      JSON.parse(OUTPUT()),
+      {
+        a: {
+          name: 'a',
+          version: '1.0.0',
+        },
+        b: {
+          name: 'b',
+          version: '1.2.3',
+        },
+      },
+      'should return expected result for configured workspaces'
+    )
+  })
 
-  t.strictSame(
-    JSON.parse(OUTPUT()),
-    {
-      a: {
+  t.test('set', async t => {
+    const { pkg, readPackageJson } = await mockWorkspaces(t)
+
+    await pkg('set', 'funding=http://example.com')
+
+    t.strictSame(
+      readPackageJson('packages/a'),
+      {
         name: 'a',
         version: '1.0.0',
+        funding: 'http://example.com',
       },
-      b: {
+      'should add field to workspace a'
+    )
+
+    t.strictSame(
+      readPackageJson('packages/b'),
+      {
         name: 'b',
         version: '1.2.3',
+        funding: 'http://example.com',
       },
-    },
-    'should return expected result for configured workspaces'
-  )
-
-  await pkg('set', 'funding=http://example.com')
-
-  t.strictSame(
-    readPackageJson('packages/a'),
-    {
-      name: 'a',
-      version: '1.0.0',
-      funding: 'http://example.com',
-    },
-    'should add field to workspace a'
-  )
-
-  t.strictSame(
-    readPackageJson('packages/b'),
-    {
-      name: 'b',
-      version: '1.2.3',
-      funding: 'http://example.com',
-    },
-    'should add field to workspace b'
-  )
+      'should add field to workspace b'
+    )
 
-  await pkg('delete', 'version')
+    await pkg('delete', 'version')
 
-  t.strictSame(
-    readPackageJson('packages/a'),
-    {
-      name: 'a',
-      funding: 'http://example.com',
-    },
-    'should delete version field from workspace a'
-  )
+    t.strictSame(
+      readPackageJson('packages/a'),
+      {
+        name: 'a',
+        funding: 'http://example.com',
+      },
+      'should delete version field from workspace a'
+    )
 
-  t.strictSame(
-    readPackageJson('packages/b'),
-    {
-      name: 'b',
-      funding: 'http://example.com',
-    },
-    'should delete version field from workspace b'
-  )
+    t.strictSame(
+      readPackageJson('packages/b'),
+      {
+        name: 'b',
+        funding: 'http://example.com',
+      },
+      'should delete version field from workspace b'
+    )
+  })
 })
 
 t.test('single workspace', async t => {