Merge commit '37aee695cf654c519243adc2945161a089855029' into release/1.15.2

* commit '37aee695cf654c519243adc2945161a089855029':
  ⚡ Release 1.15.2
  Fixes issue related to heap corruption (parse-community#1170)
  Fix parse-community#1162 - PFSubclassing.object() class method unavailable since XCode 9 beta 4 (parse-community#1164)

Author: tkhoa87

Parse.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'Parse'
-  s.version          = '1.15.1'
+  s.version          = '1.15.2'
   s.license          =  { :type => 'BSD', :file => 'LICENSE' }
   s.homepage         = 'http://parseplatform.org/'
   s.summary          = 'A library that gives you access to the powerful Parse cloud platform from your iOS/OS X/watchOS/tvOS app.'

Parse/Internal/Object/PFObjectPrivate.h

@@ -140,6 +140,22 @@
 
 @end
 
+@interface PFObject ()
+
+/**
+ Constructs an object of the most specific class known to implement `+parseClassName`.
+
+ This method takes care to help `PFObject` subclasses be subclassed themselves.
+ For example, `PFUser.+object` returns a `PFUser` by default but will return an
+ object of a registered subclass instead if one is known.
+ A default implementation is provided by `PFObject` which should always be sufficient.
+
+ @return Returns the object that is instantiated.
+ */
++ (instancetype)object;
+
+@end
+
 @interface PFObject (Private)
 
 /**

Parse/Internal/PFEventuallyQueue.h

@@ -67,7 +67,7 @@ extern NSTimeInterval const PFEventuallyQueueDefaultTimeoutRetryInterval;
 - (void)start NS_REQUIRES_SUPER;
 - (void)resume NS_REQUIRES_SUPER;
 - (void)pause NS_REQUIRES_SUPER;
-- (void)stop NS_REQUIRES_SUPER;
+- (void)terminate NS_REQUIRES_SUPER;
 - (void)removeAllCommands NS_REQUIRES_SUPER;
 
 @end

Parse/Internal/PFEventuallyQueue.m

@@ -80,10 +80,6 @@ - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource
     return self;
 }
 
-- (void)dealloc {
-    [self _stopMonitoringNetworkReachability];
-}
-
 ///--------------------------------------
 #pragma mark - Enqueueing Commands
 ///--------------------------------------
@@ -197,7 +193,8 @@ - (void)pause {
     dispatch_suspend(_processingQueueSource);
 }
 
-- (void)stop {
+- (void)terminate {
+    [self _stopMonitoringNetworkReachability];
     dispatch_source_cancel(_processingQueueSource);
 }
 
@@ -383,7 +380,6 @@ - (void)_stopMonitoringNetworkReachability {
     [[PFReachability sharedParseReachability] removeListener:self];
 
     self.monitorsReachability = NO;
-    self.connected = YES;
 #endif
 }
 
@@ -393,9 +389,11 @@ - (void)_stopMonitoringNetworkReachability {
 
 /** Manually sets the network connection status. */
 - (void)setConnected:(BOOL)connected {
+    @weakify(self);
     BFTaskCompletionSource *barrier = [BFTaskCompletionSource taskCompletionSource];
     dispatch_async(_processingQueue, ^{
         dispatch_sync(_synchronizationQueue, ^{
+            @strongify(self);
             if (self.connected != connected) {
                 _connected = connected;
                 if (connected) {

Parse/Internal/PFReachability.m

@@ -130,7 +130,9 @@ - (void)addListener:(id<PFReachabilityListener>)listener {
 }
 
 - (void)removeListener:(id<PFReachabilityListener>)listener {
+    @weakify(listener);
     dispatch_barrier_sync(_synchronizationQueue, ^{
+        @strongify(listener);
         [_listenersArray filterUsingPredicate:[NSPredicate predicateWithBlock:^BOOL(id evaluatedObject, NSDictionary *bindings) {
             id weakObject = [evaluatedObject weakObject];
             return (weakObject == nil || weakObject == listener);

Parse/Internal/ParseManager.m

@@ -181,8 +181,8 @@ - (PFEventuallyQueue *)eventuallyQueue {
                 if (commandCache.commandCount > 0) {
                     [commandCache removeAllCommands];
                 }
-                // we won't need it after stop everything...
-                [commandCache stop];
+                // we won't need it after, terminate...
+                [commandCache terminate];
             }
         }
 #endif

Parse/PFConstants.h

@@ -13,7 +13,7 @@
 #pragma mark - SDK Version
 ///--------------------------------------
 
-#define PARSE_VERSION @"1.15.1"
+#define PARSE_VERSION @"1.15.2"
 
 ///--------------------------------------
 #pragma mark - Platform

Parse/PFSubclassing.h

@@ -32,18 +32,6 @@ NS_ASSUME_NONNULL_BEGIN
 
 @optional
 
-/**
- Constructs an object of the most specific class known to implement `+parseClassName`.
-
- This method takes care to help `PFObject` subclasses be subclassed themselves.
- For example, `PFUser.+object` returns a `PFUser` by default but will return an
- object of a registered subclass instead if one is known.
- A default implementation is provided by `PFObject` which should always be sufficient.
-
- @return Returns the object that is instantiated.
- */
-+ (instancetype)object;
-
 /**
  Creates a reference to an existing PFObject for use in creating associations between PFObjects.
 

Parse/Resources/Parse-OSX.Info.plist

@@ -13,10 +13,10 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 </dict>
 </plist>

Parse/Resources/Parse-iOS.Info.plist

@@ -13,7 +13,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleSupportedPlatforms</key>
@@ -22,7 +22,7 @@
 		<string>iPhoneOS</string>
 	</array>
 	<key>CFBundleVersion</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>MinimumOSVersion</key>
 	<string>6.0</string>
 </dict>

Parse/Resources/Parse-tvOS.Info.plist

@@ -15,11 +15,11 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>NSPrincipalClass</key>
 	<string></string>
 </dict>

Parse/Resources/Parse-watchOS.Info.plist

@@ -15,11 +15,11 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1.15.1</string>
+	<string>1.15.2</string>
 	<key>NSPrincipalClass</key>
 	<string></string>
 </dict>

Tests/Unit/ProductTests.m

@@ -9,6 +9,7 @@
 
 #import "PFProduct.h"
 #import "PFUnitTestCase.h"
+#import "PFObjectPrivate.h"
 
 @interface ProductTests : PFUnitTestCase
 

Tests/Unit/PurchaseUnitTests.m

@@ -19,6 +19,7 @@
 #import "PFTestSKProduct.h"
 #import "PFUnitTestCase.h"
 #import "Parse_Private.h"
+#import "PFObjectPrivate.h"
 
 @protocol PurchaseControllerDataSource <PFCommandRunnerProvider, PFFileManagerProvider>
 

Tests/Unit/UserUnitTests.m

@@ -9,6 +9,7 @@
 
 #import "PFUnitTestCase.h"
 #import "PFUser.h"
+#import "PFObjectPrivate.h"
 
 @interface UserUnitTests : PFUnitTestCase