1- # Node.js Collaborator Guide
1+ # Node.js collaborator guide
22
33## Contents
44
3636 * [ How can I help?] ( #how-can-i-help )
3737* [ Who to CC in the issue tracker] ( #who-to-cc-in-the-issue-tracker )
3838
39- This document explains how Collaborators manage the Node.js project.
39+ This document explains how collaborators manage the Node.js project.
4040Collaborators should understand the
4141[ guidelines for new contributors] ( ../../CONTRIBUTING.md ) and the
4242[ project governance model] ( ../../GOVERNANCE.md ) .
4343
4444## Issues and pull requests
4545
46- Mind these guidelines, the opinions of other Collaborators , and guidance of the
46+ Mind these guidelines, the opinions of other collaborators , and guidance of the
4747[ TSC] [ ] . Notify other qualified parties for more input on an issue or a pull
4848request. See [ Who to CC in the issue tracker] ( #who-to-cc-in-the-issue-tracker ) .
4949
@@ -71,7 +71,7 @@ issues and pull requests can always be re-opened if necessary.
7171A pull request is _ author ready_ when:
7272
7373* There is a CI run in progress or completed.
74- * There is at least one Collaborator approval.
74+ * There is at least one collaborator approval.
7575* There are no outstanding review comments.
7676
7777Please always add the ` author ready ` label to the pull request in that case.
@@ -83,7 +83,7 @@ When you open a pull request, [start a CI](#testing-and-ci) right away. Later,
8383after new code changes or rebasing, start a new CI.
8484
8585As soon as the pull request is ready to land, please do so. This allows other
86- Collaborators to focus on other pull requests. If your pull request is not ready
86+ collaborators to focus on other pull requests. If your pull request is not ready
8787to land but is [ author ready] ( #author-ready-pull-requests ) , add the
8888` author ready ` label. If you wish to land the pull request yourself, use the
8989"assign yourself" link to self-assign it.
@@ -113,25 +113,25 @@ issues. If a user opens a security issue in the public repository:
113113## Accepting modifications
114114
115115Contributors propose modifications to Node.js using GitHub pull requests. This
116- includes modifications proposed by TSC members and other Collaborators . A pull
116+ includes modifications proposed by TSC members and other collaborators . A pull
117117request must pass code review and CI before landing into the codebase.
118118
119119### Code reviews
120120
121- At least two Collaborators must approve a pull request before the pull request
122- lands. One Collaborator approval is enough if the pull request has been open
121+ At least two collaborators must approve a pull request before the pull request
122+ lands. One collaborator approval is enough if the pull request has been open
123123for more than seven days.
124124
125- Approving a pull request indicates that the Collaborator accepts responsibility
125+ Approving a pull request indicates that the collaborator accepts responsibility
126126for the change.
127127
128- Approval must be from Collaborators who are not authors of the change.
128+ Approval must be from collaborators who are not authors of the change.
129129
130130In some cases, it might be necessary to summon a GitHub team to a pull request
131131for review by @-mention.
132132See [ Who to CC in the issue tracker] ( #who-to-cc-in-the-issue-tracker ) .
133133
134- If you are the first Collaborator to approve a pull request that has no CI yet,
134+ If you are the first collaborator to approve a pull request that has no CI yet,
135135please [ start one] ( #testing-and-ci ) . Please also start a new CI if the
136136pull request creator pushed new code since the last CI run.
137137
@@ -173,7 +173,7 @@ adding the `tsc-agenda` label to the issue.
173173
174174### Waiting for approvals
175175
176- Before landing pull requests, allow 48 hours for input from other Collaborators .
176+ Before landing pull requests, allow 48 hours for input from other collaborators .
177177Certain types of pull requests can be fast-tracked and can land after a shorter
178178delay. For example:
179179
@@ -185,14 +185,14 @@ delay. For example:
185185 * Regressions that happen right before a release, or reported soon after.
186186
187187To propose fast-tracking a pull request, apply the ` fast-track ` label. Then add
188- a comment that Collaborators can upvote.
188+ a comment that collaborators can upvote.
189189
190190If someone disagrees with the fast-tracking request, remove the label. Do not
191191fast-track the pull request in that case.
192192
193- The pull request can be fast-tracked if two Collaborators approve the
193+ The pull request can be fast-tracked if two collaborators approve the
194194fast-tracking request. To land, the pull request itself still needs two
195- Collaborator approvals and a passing CI.
195+ collaborator approvals and a passing CI.
196196
197197Collaborators can request fast-tracking of pull requests they did not author.
198198In that case only, the request itself is also one fast-track approval. Upvote
@@ -372,7 +372,7 @@ providing a Public API in such cases.
372372#### Unintended breaking changes
373373
374374Sometimes, a change intended to be non-breaking turns out to be a breaking
375- change. If such a change lands on the master branch, a Collaborator can revert
375+ change. If such a change lands on the master branch, a collaborator can revert
376376it. As an alternative to reverting, the TSC can apply the semver-major label
377377after-the-fact.
378378
@@ -474,7 +474,7 @@ Do this if a pull request or issue:
474474* Is labeled ` semver-major ` , or
475475* Has a significant impact on the codebase, or
476476* Is controversial, or
477- * Is at an impasse among Collaborators who are participating in the discussion.
477+ * Is at an impasse among collaborators who are participating in the discussion.
478478
479479@-mention the ` @nodejs/tsc ` GitHub team if you want to elevate an issue to the
480480[ TSC] [ ] . Do not use the GitHub UI on the right-hand side to assign to
@@ -659,7 +659,7 @@ for that commit. This is an opportunity to fix commit messages.
659659 issue. A commit message can include more than one ` Fixes: ` lines.
660660 * Optional: One or more ` Refs: ` lines referencing a URL for any relevant
661661 background.
662- * Required: A ` Reviewed-By: Name <email> ` line for each Collaborator who
662+ * Required: A ` Reviewed-By: Name <email> ` line for each collaborator who
663663 reviewed the change.
664664 * Useful for @mentions / contact list if something goes wrong in the
665665 pull request.
@@ -775,7 +775,7 @@ There are several LTS-related labels:
775775 release. For example, ` land-on-v10.x ` would be for a change to land in Node.js
776776 10.x.
777777
778- Any Collaborator can attach these labels to any pull request/issue. As commits
778+ Any collaborator can attach these labels to any pull request/issue. As commits
779779land on the staging branches, the backporter removes the ` lts-watch- ` label.
780780Likewise, as commits land in an LTS release, the releaser removes the ` land-on- `
781781label.
@@ -847,7 +847,7 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` can help.
847847
848848* ` author-ready ` - A pull request is _ author ready_ when:
849849 * There is a CI run in progress or completed.
850- * There is at least one Collaborator approval (or two TSC approvals for
850+ * There is at least one collaborator approval (or two TSC approvals for
851851 semver-major pull requests).
852852 * There are no outstanding review comments.
853853
0 commit comments