buffer: fix MAX_LENGTH constant export

This was a typo and accidentally returned the wrong value.

Fixes: #14819
Ref: #13467
PR-URL: #14821
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

Author: addaleax

lib/buffer.js

@@ -47,7 +47,7 @@ exports.kMaxLength = binding.kMaxLength;
 
 const constants = Object.defineProperties({}, {
   MAX_LENGTH: {
-    value: binding.kStringMaxLength,
+    value: binding.kMaxLength,
     writable: false,
     enumerable: true
   },

test/parallel/test-buffer-constants.js

@@ -2,6 +2,7 @@
 require('../common');
 const assert = require('assert');
 
+const { kMaxLength, kStringMaxLength } = require('buffer');
 const { MAX_LENGTH, MAX_STRING_LENGTH } = require('buffer').constants;
 
 assert.strictEqual(typeof MAX_LENGTH, 'number');
@@ -11,3 +12,7 @@ assert.throws(() => ' '.repeat(MAX_STRING_LENGTH + 1),
               /^RangeError: Invalid string length$/);
 
 assert.doesNotThrow(() => ' '.repeat(MAX_STRING_LENGTH));
+
+// Legacy values match:
+assert.strictEqual(kMaxLength, MAX_LENGTH);
+assert.strictEqual(kStringMaxLength, MAX_STRING_LENGTH);