fixup! util: print External address from inspect

Author: rosaxxny

lib/internal/util/inspect.js

@@ -979,7 +979,7 @@ function formatRaw(ctx, value, recurseTimes, typedArray) {
     } else {
       if (keys.length === 0 && protoProps === undefined) {
         if (isExternal(value)) {
-          const address = getExternalValue(value);
+          const address = getExternalValue(value).toString(16);
           return ctx.stylize(`[External: ${address}]`, 'special');
         }
         return `${getCtxStyle(value, constructor, tag)}{}`;

src/node_util.cc

@@ -9,6 +9,7 @@ namespace util {
 using v8::ALL_PROPERTIES;
 using v8::Array;
 using v8::ArrayBufferView;
+using v8::BigInt;
 using v8::Boolean;
 using v8::Context;
 using v8::External;
@@ -73,15 +74,13 @@ static void GetConstructorName(
 static void GetExternalValue(
     const FunctionCallbackInfo<Value>& args) {
   CHECK(args[0]->IsExternal());
-  auto isolate = args.GetIsolate();
+  Isolate* isolate = args.GetIsolate();
   Local<External> external = args[0].As<External>();
 
   void* ptr = external->Value();
-  char val[20];
-  snprintf(val, sizeof(val), "%p", ptr);
-
-  MaybeLocal<String> ret = String::NewFromUtf8(isolate, val);
-  args.GetReturnValue().Set(ret.ToLocalChecked());
+  uint64_t value = reinterpret_cast<uint64_t>(ptr);
+  Local<BigInt> ret = BigInt::NewFromUnsigned(isolate, value);
+  args.GetReturnValue().Set(ret);
 }
 
 static void GetPromiseDetails(const FunctionCallbackInfo<Value>& args) {

test/parallel/test-util-inspect.js

@@ -148,7 +148,7 @@ assert.strictEqual(
 );
 
 assert.match(util.inspect((new JSStream())._externalStream),
-             /^\[External: .*?\]$/);
+             /^\[External: [0-9a-f]+\]$/);
 
 {
   const regexp = /regexp/;