url: ensure host setter matches parse for file url

Technically, file URLs are not permitted to have a port. There is
currently an ambiguity in the URL spec. In the current spec
having a port in a file URL is undefined behavior. In the current
implementation, the port is ignored and handled as if it were part
of the host name. This will be changing once the ambiguity is
resolved in the spec. The spec change may involve either ignoring the
port if specified or throwing with an Invalid URL error if the port
is specified. For now, this test verifies the currently implemented
behavior.

Fixes: #10608

Author: jasnell

lib/internal/url.js

@@ -434,7 +434,9 @@ Object.defineProperties(URL.prototype, {
         ctx.flags &= ~binding.URL_FLAGS_HAS_HOST;
         return;
       }
-      binding.parse(host, binding.kHost, null, ctx,
+      const override = ctx.scheme === 'file:' ?
+                       binding.kFileHost : binding.kHost;
+      binding.parse(host, override, null, ctx,
                     onParseHostComplete.bind(this));
     }
   },

test/parallel/test-whatwg-url-filehostport.js

@@ -0,0 +1,30 @@
+'use strict';
+
+// Technically, file URLs are not permitted to have a port. There is
+// currently an ambiguity in the URL spec. In the current spec
+// having a port in a file URL is undefined behavior. In the current
+// implementation, the port is ignored and handled as if it were part
+// of the host name. This will be changing once the ambiguity is
+// resolved in the spec. The spec change may involve either ignoring the
+// port if specified or throwing with an Invalid URL error if the port
+// is specified. For now, this test verifies the currently implemented
+// behavior.
+
+require('../common');
+const URL = require('url').URL;
+const assert = require('assert');
+
+const u = new URL('file://example.net:80/foo');
+
+assert.strictEqual(u.hostname, 'example.net:80');
+assert.strictEqual(u.port, '');
+
+u.host = 'example.com:81';
+
+assert.strictEqual(u.hostname, 'example.com:81');
+assert.strictEqual(u.port, '');
+
+u.hostname = 'example.org:81';
+
+assert.strictEqual(u.hostname, 'example.org');
+assert.strictEqual(u.port, '');