test: use tmpdir.resolve()

PR-URL: #49128
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

Author: LiviaMedeiros

test/parallel/test-common.js

@@ -27,7 +27,6 @@ const tmpdir = require('../common/tmpdir');
 const assert = require('assert');
 const { execFile } = require('child_process');
 const { writeFileSync, existsSync } = require('fs');
-const { join } = require('path');
 
 // Test for leaked global detection
 {
@@ -134,7 +133,7 @@ const HIJACK_TEST_ARRAY = [ 'foo\n', 'bar\n', 'baz\n' ];
 {
   tmpdir.refresh();
   assert.match(tmpdir.path, /\.tmp\.\d+/);
-  const sentinelPath = join(tmpdir.path, 'gaga');
+  const sentinelPath = tmpdir.resolve('gaga');
   writeFileSync(sentinelPath, 'googoo');
   tmpdir.refresh();
   assert.strictEqual(existsSync(tmpdir.path), true);

test/parallel/test-debugger-heap-profiler.js

@@ -6,13 +6,12 @@ common.skipIfInspectorDisabled();
 const fixtures = require('../common/fixtures');
 const startCLI = require('../common/debugger');
 const tmpdir = require('../common/tmpdir');
-const path = require('path');
 
 tmpdir.refresh();
 
 const { readFileSync } = require('fs');
 
-const filename = path.join(tmpdir.path, 'node.heapsnapshot');
+const filename = tmpdir.resolve('node.heapsnapshot');
 
 // Heap profiler take snapshot.
 {

test/parallel/test-file-write-stream.js

@@ -23,10 +23,9 @@
 const common = require('../common');
 const assert = require('assert');
 
-const path = require('path');
 const fs = require('fs');
 const tmpdir = require('../common/tmpdir');
-const fn = path.join(tmpdir.path, 'write.txt');
+const fn = tmpdir.resolve('write.txt');
 tmpdir.refresh();
 const file = fs.createWriteStream(fn, {
   highWaterMark: 10

test/parallel/test-file-write-stream2.js

@@ -23,13 +23,12 @@
 require('../common');
 const assert = require('assert');
 
-const path = require('path');
 const fs = require('fs');
 
 const tmpdir = require('../common/tmpdir');
 
 
-const filepath = path.join(tmpdir.path, 'write.txt');
+const filepath = tmpdir.resolve('write.txt');
 
 const EXPECTED = '012345678910';
 

test/parallel/test-file-write-stream3.js

@@ -22,13 +22,12 @@
 'use strict';
 const common = require('../common');
 const assert = require('assert');
-const path = require('path');
 const fs = require('fs');
 
 const tmpdir = require('../common/tmpdir');
 
 
-const filepath = path.join(tmpdir.path, 'write_pos.txt');
+const filepath = tmpdir.resolve('write_pos.txt');
 
 
 const cb_expected = 'write open close write open close write open close ';

test/parallel/test-file-write-stream4.js

@@ -4,13 +4,12 @@
 // Refs: https://github.com/nodejs/node/issues/31366
 
 const common = require('../common');
-const path = require('path');
 const fs = require('fs');
 
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-const filepath = path.join(tmpdir.path, 'write_pos.txt');
+const filepath = tmpdir.resolve('write_pos.txt');
 
 const fileReadStream = fs.createReadStream(process.execPath);
 const fileWriteStream = fs.createWriteStream(filepath, {

test/parallel/test-heap-prof-dir-absolute.js

@@ -9,7 +9,6 @@ common.skipIfInspectorDisabled();
 
 const assert = require('assert');
 const fs = require('fs');
-const path = require('path');
 const { spawnSync } = require('child_process');
 
 const tmpdir = require('../common/tmpdir');
@@ -24,7 +23,7 @@ const {
 // Tests absolute --heap-prof-dir
 {
   tmpdir.refresh();
-  const dir = path.join(tmpdir.path, 'prof');
+  const dir = tmpdir.resolve('prof');
   const output = spawnSync(process.execPath, [
     '--heap-prof',
     '--heap-prof-dir',

test/parallel/test-heap-prof-dir-name.js

@@ -23,7 +23,7 @@ const {
 
 {
   tmpdir.refresh();
-  const dir = path.join(tmpdir.path, 'prof');
+  const dir = tmpdir.resolve('prof');
   const file = path.join(dir, 'test.heapprofile');
   const output = spawnSync(process.execPath, [
     '--heap-prof',

test/parallel/test-heap-prof-dir-relative.js

@@ -9,7 +9,6 @@ common.skipIfInspectorDisabled();
 
 const assert = require('assert');
 const fs = require('fs');
-const path = require('path');
 const { spawnSync } = require('child_process');
 
 const tmpdir = require('../common/tmpdir');
@@ -38,7 +37,7 @@ const {
     console.log(output.stderr.toString());
   }
   assert.strictEqual(output.status, 0);
-  const dir = path.join(tmpdir.path, 'prof');
+  const dir = tmpdir.resolve('prof');
   assert(fs.existsSync(dir));
   const profiles = getHeapProfiles(dir);
   assert.strictEqual(profiles.length, 1);

test/parallel/test-heap-prof-interval.js

@@ -9,7 +9,6 @@ common.skipIfInspectorDisabled();
 
 const assert = require('assert');
 const fs = require('fs');
-const path = require('path');
 const { spawnSync } = require('child_process');
 
 const tmpdir = require('../common/tmpdir');
@@ -38,7 +37,7 @@ const {
     console.log(output.stderr.toString());
   }
   assert.strictEqual(output.status, 0);
-  const dir = path.join(tmpdir.path, 'prof');
+  const dir = tmpdir.resolve('prof');
   assert(fs.existsSync(dir));
   const profiles = getHeapProfiles(dir);
   assert.strictEqual(profiles.length, 2);