fix crash

Author: jazelly

src/node_messaging.cc

@@ -139,13 +139,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
     if (!deserializer->ReadUint32(&id))
       return MaybeLocal<Object>();
 
-    EscapableHandleScope scope(isolate);
-    Local<Context> context = isolate->GetCurrentContext();
-    if (id == kDOMExceptionTag) {
-      return ReadDOMException(isolate, context, deserializer);
-    }
-
-    if (id != kNormalObject) {
+    if (id != kNormalObject && id != kDOMExceptionTag) {
       CHECK_LT(id, host_objects_.size());
       Local<Object> object = host_objects_[id]->object(isolate);
       if (env_->js_transferable_constructor_template()->HasInstance(object)) {
@@ -154,6 +148,12 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
         return object;
       }
     }
+
+    EscapableHandleScope scope(isolate);
+    Local<Context> context = isolate->GetCurrentContext();
+    if (id == kDOMExceptionTag) {
+      return ReadDOMException(isolate, context, deserializer);
+    }
     Local<Value> object;
     if (!deserializer->ReadValue(context).ToLocal(&object))
       return MaybeLocal<Object>();
@@ -424,21 +424,11 @@ Maybe<bool> IsDOMException(Isolate* isolate,
                            Local<Object> obj) {
   HandleScope handle_scope(isolate);
 
-  Local<Object> per_context_bindings;
   Local<Value> dom_exception_ctor_val;
-
-  if (!GetPerContextExports(context).ToLocal(&per_context_bindings)) {
+  if (!GetDOMException(context).ToLocal(&dom_exception_ctor_val)) {
     return Just(false);
   }
 
-  if (!per_context_bindings
-           ->Get(context,
-                 FIXED_ONE_BYTE_STRING(isolate, "DOMException"))
-           .ToLocal(&dom_exception_ctor_val) ||
-      !dom_exception_ctor_val->IsFunction()) {
-    return Nothing<bool>();
-  }
-
   Local<Function> dom_exception_ctor = dom_exception_ctor_val.As<Function>();
   Local<Value> obj_constructor;
   if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "constructor"))

test/parallel/test-structuredClone-global.js

@@ -104,7 +104,7 @@ for (const Transferrable of [File, Blob]) {
 
 {
   const obj = {};
-  obj.setPrototypeOf(DOMException.prototype);
+  Object.setPrototypeOf(obj, DOMException.prototype);
   const clone = structuredClone(obj);
   assert.strictEqual(clone instanceof DOMException, false);
 }