Skip to content

Commit 3309c85

Browse files
lpincadanbev
authored andcommitted
http2: do not override the allowHalfOpen option
The constructors of `tls.Server` and `Http2Server` call the super constructors without options so the `allowHalfOpen` option is never used regardless of its value. PR-URL: #27623 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 639b859 commit 3309c85

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/internal/http2/core.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2641,7 +2641,6 @@ function connectionListener(socket) {
26412641
function initializeOptions(options) {
26422642
assertIsObject(options, 'options');
26432643
options = { ...options };
2644-
options.allowHalfOpen = true;
26452644
assertIsObject(options.settings, 'options.settings');
26462645
options.settings = { ...options.settings };
26472646

0 commit comments

Comments
 (0)