Skip to content

Commit 2f5b9a4

Browse files
committed
src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but implied that node would load modules with newer ABI numbers, which it will not.
1 parent 9e4a899 commit 2f5b9a4

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/node_version.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@
4444
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))
4545

4646
/**
47+
* Node.js will refuse to load modules that weren't compiled against its own
48+
* module ABI number, exposed as the process.versions.modules property.
49+
*
4750
* When this version number is changed, node.js will refuse
4851
* to load older modules. This should be done whenever
4952
* an API is broken in the C++ side, including in v8 or

0 commit comments

Comments
 (0)