test: ensure finish is emitted before destroy

Adds a test to ensure that 'finish' is emitted
before the socket is destroyed by allow half-open
enforcer.

Refs: 3c07b17#commitcomment-38810268

PR-URL: #33137
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Author: ronag

test/parallel/test-net-allow-half-open.js

@@ -4,22 +4,44 @@ const common = require('../common');
 const assert = require('assert');
 const net = require('net');
 
-const server = net.createServer(common.mustCall((socket) => {
-  socket.end(Buffer.alloc(1024));
-})).listen(0, common.mustCall(() => {
-  const socket = net.connect(server.address().port);
-  assert.strictEqual(socket.allowHalfOpen, false);
-  socket.resume();
-  socket.on('end', common.mustCall(() => {
-    process.nextTick(() => {
-      // Ensure socket is not destroyed straight away
-      // without proper shutdown.
+{
+  const server = net.createServer(common.mustCall((socket) => {
+    socket.end(Buffer.alloc(1024));
+  })).listen(0, common.mustCall(() => {
+    const socket = net.connect(server.address().port);
+    assert.strictEqual(socket.allowHalfOpen, false);
+    socket.resume();
+    socket.on('end', common.mustCall(() => {
+      process.nextTick(() => {
+        // Ensure socket is not destroyed straight away
+        // without proper shutdown.
+        assert(!socket.destroyed);
+        server.close();
+      });
+    }));
+    socket.on('finish', common.mustCall(() => {
       assert(!socket.destroyed);
-      server.close();
-    });
+    }));
+    socket.on('close', common.mustCall());
   }));
-  socket.on('finish', common.mustCall(() => {
-    assert(!socket.destroyed);
+}
+
+{
+  const server = net.createServer(common.mustCall((socket) => {
+    socket.end(Buffer.alloc(1024));
+  })).listen(0, common.mustCall(() => {
+    const socket = net.connect(server.address().port);
+    assert.strictEqual(socket.allowHalfOpen, false);
+    socket.resume();
+    socket.on('end', common.mustCall(() => {
+      assert(!socket.destroyed);
+    }));
+    socket.end('asd');
+    socket.on('finish', common.mustCall(() => {
+      assert(!socket.destroyed);
+    }));
+    socket.on('close', common.mustCall(() => {
+      server.close();
+    }));
   }));
-  socket.on('close', common.mustCall());
-}));
+}