Skip to content

Commit 0fda693

Browse files
committed
buffer: validate UTF8 on fast path
Fast API handles invalid UTF differently than the slow API. Fixes: #54521 PR-URL: #54525
1 parent d5dc540 commit 0fda693

File tree

2 files changed

+38
-1
lines changed

2 files changed

+38
-1
lines changed

src/node_buffer.cc

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1489,6 +1489,32 @@ uint32_t FastWriteString(Local<Value> receiver,
14891489

14901490
static v8::CFunction fast_write_string(v8::CFunction::Make(FastWriteString));
14911491

1492+
uint32_t FastWriteStringUTF8(Local<Value> receiver,
1493+
const v8::FastApiTypedArray<uint8_t>& dst,
1494+
const v8::FastOneByteString& src,
1495+
uint32_t offset,
1496+
uint32_t max_length,
1497+
v8::FastApiCallbackOptions& options) {
1498+
uint8_t* dst_data;
1499+
CHECK(dst.getStorageIfAligned(&dst_data));
1500+
CHECK(offset <= dst.length());
1501+
CHECK(dst.length() - offset <= std::numeric_limits<uint32_t>::max());
1502+
1503+
const auto size = std::min(
1504+
{static_cast<uint32_t>(dst.length() - offset), max_length, src.length});
1505+
1506+
if (!simdutf::validate_utf8(src.data, size)) {
1507+
options.fallback = true;
1508+
return 0;
1509+
}
1510+
1511+
memcpy(dst_data + offset, src.data, size);
1512+
1513+
return size;
1514+
}
1515+
1516+
static v8::CFunction fast_write_string_utf8(v8::CFunction::Make(FastWriteStringUTF8));
1517+
14921518
void Initialize(Local<Object> target,
14931519
Local<Value> unused,
14941520
Local<Context> context,
@@ -1568,7 +1594,7 @@ void Initialize(Local<Object> target,
15681594
target,
15691595
"utf8WriteStatic",
15701596
SlowWriteString<UTF8>,
1571-
&fast_write_string);
1597+
&fast_write_string_utf8);
15721598

15731599
SetMethod(context, target, "getZeroFillToggle", GetZeroFillToggle);
15741600
}
@@ -1615,6 +1641,8 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
16151641
registry->Register(SlowWriteString<UTF8>);
16161642
registry->Register(fast_write_string.GetTypeInfo());
16171643
registry->Register(FastWriteString);
1644+
registry->Register(fast_write_string_utf8.GetTypeInfo());
1645+
registry->Register(FastWriteStringUTF8);
16181646
registry->Register(StringWrite<ASCII>);
16191647
registry->Register(StringWrite<BASE64>);
16201648
registry->Register(StringWrite<BASE64URL>);

src/node_external_reference.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,14 @@ using CFunctionWriteString =
6363
uint32_t offset,
6464
uint32_t max_length);
6565

66+
using CFunctionWriteStringFallback =
67+
uint32_t (*)(v8::Local<v8::Value> receiver,
68+
const v8::FastApiTypedArray<uint8_t>& dst,
69+
const v8::FastOneByteString& src,
70+
uint32_t offset,
71+
uint32_t max_length,
72+
v8::FastApiCallbackOptions& options);
73+
6674
using CFunctionBufferCopy =
6775
uint32_t (*)(v8::Local<v8::Value> receiver,
6876
const v8::FastApiTypedArray<uint8_t>& source,
@@ -96,6 +104,7 @@ class ExternalReferenceRegistry {
96104
V(CFunctionWithBool) \
97105
V(CFunctionBufferCopy) \
98106
V(CFunctionWriteString) \
107+
V(CFunctionWriteStringFallback) \
99108
V(const v8::CFunctionInfo*) \
100109
V(v8::FunctionCallback) \
101110
V(v8::AccessorNameGetterCallback) \

0 commit comments

Comments
 (0)