fs: throw ERR_INVALID_THIS on illegal invocations

PR-URL: #58848
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Author: LiviaMedeiros

lib/internal/fs/dir.js

@@ -16,6 +16,7 @@ const {
   codes: {
     ERR_DIR_CLOSED,
     ERR_DIR_CONCURRENT_OPERATION,
+    ERR_INVALID_THIS,
     ERR_MISSING_ARGS,
   },
 } = require('internal/errors');
@@ -67,6 +68,8 @@ class Dir {
   }
 
   get path() {
+    if (!(#path in this))
+      throw new ERR_INVALID_THIS('Dir');
     return this.#path;
   }
 

lib/internal/fs/streams.js

@@ -26,6 +26,7 @@ const {
   validateBoolean,
   validateFunction,
   validateInteger,
+  validateThisInternalField,
 } = require('internal/validators');
 const { errorOrDestroy } = require('internal/streams/destroy');
 const fs = require('fs');
@@ -231,9 +232,11 @@ ObjectSetPrototypeOf(ReadStream, Readable);
 ObjectDefineProperty(ReadStream.prototype, 'autoClose', {
   __proto__: null,
   get() {
+    validateThisInternalField(this, kFs, 'ReadStream');
     return this._readableState.autoDestroy;
   },
   set(val) {
+    validateThisInternalField(this, kFs, 'ReadStream');
     this._readableState.autoDestroy = val;
   },
 });
@@ -400,9 +403,11 @@ ObjectSetPrototypeOf(WriteStream, Writable);
 ObjectDefineProperty(WriteStream.prototype, 'autoClose', {
   __proto__: null,
   get() {
+    validateThisInternalField(this, kFs, 'WriteStream');
     return this._writableState.autoDestroy;
   },
   set(val) {
+    validateThisInternalField(this, kFs, 'WriteStream');
     this._writableState.autoDestroy = val;
   },
 });

test/parallel/test-fs-opendir.js

@@ -18,6 +18,13 @@ files.forEach(function(filename) {
   fs.closeSync(fs.openSync(path.join(testDir, filename), 'w'));
 });
 
+function assertDir(dir) {
+  assert(dir instanceof fs.Dir);
+  assert.throws(() => dir.constructor.prototype.path, {
+    code: 'ERR_INVALID_THIS',
+  });
+}
+
 function assertDirent(dirent) {
   assert(dirent instanceof fs.Dirent);
   assert.strictEqual(dirent.isFile(), true);
@@ -45,6 +52,7 @@ const invalidCallbackObj = {
 // Check the opendir Sync version
 {
   const dir = fs.opendirSync(testDir);
+  assertDir(dir);
   const entries = files.map(() => {
     const dirent = dir.readSync();
     assertDirent(dirent);
@@ -68,6 +76,7 @@ const invalidCallbackObj = {
 
 // Check the opendir async version
 fs.opendir(testDir, common.mustSucceed((dir) => {
+  assertDir(dir);
   let sync = true;
   dir.read(common.mustSucceed((dirent) => {
     assert(!sync);
@@ -121,6 +130,7 @@ fs.opendir(__filename, common.mustCall(function(e) {
 async function doPromiseTest() {
   // Check the opendir Promise version
   const dir = await fs.promises.opendir(testDir);
+  assertDir(dir);
   const entries = [];
 
   let i = files.length;

test/parallel/test-fs-write-stream-autoclose-option.js

@@ -56,3 +56,7 @@ function next3() {
     }));
   }));
 }
+
+assert.throws(() => fs.WriteStream.prototype.autoClose, {
+  code: 'ERR_INVALID_THIS',
+});