build: i18n: support --with-icu-source=URL

Allow local path or URL to .tgz/.zip/etc to be used.

This completes https://github.com/srl295/node/issues/11

Author: srl295

README.md

@@ -152,17 +152,29 @@ pkg-config --modversion icu-i18n && ./configure --with-intl=system-icu
 
 #### Build with a specific ICU:
 
-First: Unpack latest ICU to `deps/icu`
-  [icu4c-**##.#**-src.tgz](http://icu-project.org/download) (or `.zip`)
-  as `deps/icu` (You'll have: `deps/icu/source/...`)
+You can find other ICU releases at [icu4c-**##.#**-src.tgz](http://icu-project.org/download) (or `.zip`)
 
-Unix/Macintosh:
+Unix/Macintosh: from an already-unpacked ICU
 
 ```sh
-./configure --with-intl=full-icu
+./configure --with-intl=full-icu --with-icu-source=/path/to/icu
 ```
 
-Windows:
+Unix/Macintosh: from a local ICU tarball
+
+```sh
+./configure --with-intl=full-icu --with-icu-source=/path/to/icu.tgz
+```
+
+Unix/Macintosh: from a tarball URL
+
+```sh
+./configure --with-intl=full-icu --with-icu-source=http://url/to/icu.tgz
+```
+
+Windows: first unpack latest ICU to `deps/icu`
+  [icu4c-**##.#**-src.tgz](http://icu-project.org/download) (or `.zip`)
+  as `deps/icu` (You'll have: `deps/icu/source/...`) 
 
 ```sh
 vcbuild full-icu

configure

@@ -254,7 +254,7 @@ parser.add_option('--with-intl',
 parser.add_option('--with-icu-source',
     action='store',
     dest='with_icu_source',
-    help='Intl mode: optional local path to ICU source archive or existing icu directory.')
+    help='Intl mode: optional local path to icu/ dir, or path/URL of icu source archive.')
 
 parser.add_option('--with-perfctr',
     action='store_true',
@@ -835,9 +835,9 @@ def configure_intl(o):
         # it's a file. Try to unpack it.
         icu_tarball = with_icu_source
       else:
-        # download tarball
-        print 'file missing and cant download'
-        sys.exit(1)
+        # Can we download it?
+        local = os.path.join(icu_tmp_path, with_icu_source.split('/')[-1])  # local part
+        icu_tarball = nodedownload.retrievefile(with_icu_source, local)
       # continue with "icu_tarball"
       nodedownload.unpack(icu_tarball, icu_tmp_path)
       # Did it unpack correctly? Should contain 'icu'

tools/configure.d/nodedownload.py

@@ -51,23 +51,23 @@ def md5sum(targetfile):
         chunk = f.read(1024)
     return digest.hexdigest()
 
-def unpackWithMode(unpacker, packedfile, parent_path, mode):
-    with unpacker.open(packedfile, mode) as icuzip:
+def unpackWithMode(opener, packedfile, parent_path, mode):
+    with opener(packedfile, mode) as icuzip:
         print ' Extracting source file: %s' % packedfile
         icuzip.extractall(parent_path)
 
 def unpack(packedfile, parent_path):
-    """Unpack packedfile into parent_path. Assumes .zip."""
+    """Unpack packedfile into parent_path. Assumes .zip. Returns parent_path"""
     packedsuffix = packedfile.lower().split('.')[-1]  # .zip, .tgz etc
     if zipfile.is_zipfile(packedfile):
-        unpackWithMode(zipfile.ZipFile, packedfile, parent_path, 'r')
+        with zipfile.ZipFile(packedfile, 'r') as icuzip:
+            print ' Extracting zipfile: %s' % packedfile
+            icuzip.extractall(parent_path)
+            return parent_path
     elif tarfile.is_tarfile(packedfile):
-        # if (packedsuffix == 'tgz') or (packedsuffix == 'gz'):
-        #     unpackWithMode(tarfile.TarFile, packedfile, parent_path, 'r:gz')
-        # elif (packedsuffix == 'bz2') or (packedsuffix == 'tb2'):
-        #     unpackWithMode(tarfile.TarFile, packedfile, parent_path, 'r:bz2')
-        # else:
-            unpackWithMode(tarfile.TarFile, packedfile, parent_path, 'r')
-            #raise Exception('Error: Don\'t know how to unpack tarfile %s with extension %s' % (packedfile, packedsuffix))
+        with tarfile.TarFile.open(packedfile, 'r') as icuzip:
+            print ' Extracting tarfile: %s' % packedfile
+            icuzip.extractall(parent_path)
+            return parent_path
     else:
         raise Exception('Error: Don\'t know how to unpack %s with extension %s' % (packedfile, packedsuffix))