fixup! fixup! ncu-ci: initial implementation

Author: joyeecheung

bin/ncu-ci

@@ -3,11 +3,12 @@
 'use strict';
 
 const {
-  PRBuild, BenchmarkRun, CommitBuild, jobCache
+  PRBuild, BenchmarkRun, CommitBuild, jobCache, parseJobFromURL
 } = require('../components/jenkins');
 const { runPromise } = require('../lib/run');
 const Request = require('../lib/request');
 const CLI = require('../lib/cli');
+const { parsePRFromURL } = require('../lib/links');
 const yargs = require('yargs');
 
 // This is used for testing
@@ -73,10 +74,10 @@ const argv = yargs
   .help()
   .argv;
 
-async function getResults(cli, request, command, argv) {
+async function getResults(cli, request, job) {
   let build;
-  const { jobid, markdown } = argv;
-  switch (command) {
+  const { type, jobid, markdown } = job;
+  switch (type) {
     case 'pr':
       build = new PRBuild(cli, request, jobid);
       await build.getResults();
@@ -107,9 +108,30 @@ async function main(command, argv) {
   const queue = [];
 
   if (command === 'url') {
-
+    let parsed = parseJobFromURL(argv.url);
+    if (parsed) {
+      queue.push({
+        type: parsed.command,
+        jobid: parsed.jobid,
+        markdown: argv.markdown
+      });
+    } else {
+      parsed = parsePRFromURL(argv.url);
+      if (parsed) {
+        // Get OP and comments from the PR
+        // const ciMap = new JobParser(thread).parse();
+      }
+    }
+  } else {
+    queue.push({
+      type: command,
+      argv: argv
+    });
   }
 
+  for (let job of queue) {
+    await getResults(cli, request, job);
+  }
 }
 
 function handler(argv) {

components/jenkins.js

@@ -5,7 +5,7 @@ const qs = require('querystring');
 const chalk = require('chalk');
 const { appendFile } = require('../lib/file');
 
-const DOMAIN = 'ci.nodejs.org';
+const CI_DOMAIN = 'ci.nodejs.org';
 
 const SUCCESS = 'SUCCESS';
 const FAILURE = 'FAILURE';
@@ -33,11 +33,11 @@ const BUILD_TREE = 'result,runs[url,number,result]';
 const LINTER_TREE = 'result,url,number';
 
 function getPath(url) {
-  return url.replace(`https://${DOMAIN}/`, '').replace('api/json', '');
+  return url.replace(`https://${CI_DOMAIN}/`, '').replace('api/json', '');
 }
 
 function getUrl(path) {
-  return `https://${DOMAIN}/${getPath(path)}`;
+  return `https://${CI_DOMAIN}/${getPath(path)}`;
 }
 
 function resultName(result) {
@@ -87,7 +87,7 @@ class Job {
 
   get jobUrl() {
     const { path } = this;
-    return `https://${DOMAIN}/${path}`;
+    return `https://${CI_DOMAIN}/${path}`;
   }
 
   get apiUrl() {
@@ -98,12 +98,12 @@ class Job {
 
   get consoleUrl() {
     const { path } = this;
-    return `https://${DOMAIN}/${path}consoleText`;
+    return `https://${CI_DOMAIN}/${path}consoleText`;
   }
 
   get consoleUIUrl() {
     const { path } = this;
-    return `https://${DOMAIN}/${path}console`;
+    return `https://${CI_DOMAIN}/${path}console`;
   }
 
   async getBuildData() {
@@ -526,6 +526,10 @@ const FAILURE_PATTERNS = [{
   pattern: /FATAL: .+/g,
   filter: pickReason(-1, 0, 5),
   name: 'build failure'
+}, {
+  pattern: /error: .+/g,
+  filter: pickReason(-1, 0, 5),
+  name: 'build failure'
 }, {
   pattern: /make.*: write error/mg,
   filter: pickReason(0, 0, 3),