Skip to content

Commit 888ed50

Browse files
VerteDindekkoopa
authored andcommitted
fix: bump nmv version down, add dummy sig
1 parent 7f9ceb8 commit 888ed50

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

nan.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2550,7 +2550,7 @@ NAN_DEPRECATED inline void SetAccessor(
25502550
, obj
25512551
, settings
25522552
, attribute
2553-
#if (NODE_MODULE_VERSION < NODE_18_0_MODULE_VERSION)
2553+
#if (NODE_MODULE_VERSION < NODE_16_0_MODULE_VERSION)
25542554
, signature
25552555
#endif
25562556
);

nan_callbacks.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,10 @@ typedef void(*IndexQueryCallback)(
5252
const PropertyCallbackInfo<v8::Integer>&);
5353

5454
namespace imp {
55-
#if (NODE_MODULE_VERSION < NODE_18_0_MODULE_VERSION)
56-
NAN_DEPRECATED typedef v8::Local<v8::AccessorSignature> Sig;
55+
#if (NODE_MODULE_VERSION < NODE_16_0_MODULE_VERSION)
56+
typedef v8::Local<v8::AccessorSignature> Sig;
57+
#else
58+
typedef v8::Local<v8::Data> Sig;
5759
#endif
5860

5961
static const int kDataIndex = 0;

0 commit comments

Comments
 (0)