doc: path is ignored in url.format #1753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it obvious that path is ignored in url.format
|
I see what you mean there, but it might not be obvious to a new reader. I suggest adding something like this instead: |
|
OTOH, that would duplicate information on pathname below, so LGTM. |
silverwind
pushed a commit
that referenced
this pull request
May 22, 2015
Made it obvious that path is ignored in url.format PR-URL: #1753
|
Thanks, landed in 515afc6 |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Made it obvious that path is ignored in url.format PR-URL: nodejs/node#1753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it obvious that path is ignored in url.format