Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Don't abort silently a test if a strict-mode check fails. #161

Conversation

vincentbernat
Copy link

In test_message_pause(), we don't expect a strict-mode check to
fail. Don't abort silently the test if it is the case. Raise an assert
error instead. We keep a separate assert to help with debugging.

In `test_message_pause()`, we don't expect a strict-mode check to
fail. Don't abort silently the test if it is the case. Raise an assert
error instead. We keep a separate assert to help with debugging.
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

@indutny ... I assume this one is safe to close given the lack of any activity on it. Can reopen if someone feels it is necessary.

@vincentbernat
Copy link
Author

The commit still applies and the problem is still here. I cannot reopen myself the PR and pushing a rebase has no effect.

@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

I'll mark this one for a second look. It's not letting me re-open the PR either for some reason.

@jasnell jasnell self-assigned this Oct 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants