This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Don't abort silently a test if a strict-mode check fails. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `test_message_pause()`, we don't expect a strict-mode check to fail. Don't abort silently the test if it is the case. Raise an assert error instead. We keep a separate assert to help with debugging.
|
@indutny ... I assume this one is safe to close given the lack of any activity on it. Can reopen if someone feels it is necessary. |
|
The commit still applies and the problem is still here. I cannot reopen myself the PR and pushing a rebase has no effect. |
|
I'll mark this one for a second look. It's not letting me re-open the PR either for some reason. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
test_message_pause(), we don't expect a strict-mode check tofail. Don't abort silently the test if it is the case. Raise an assert
error instead. We keep a separate assert to help with debugging.