Skip to content

fix: handle 0.0.0.0:port binding #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2017
Merged

fix: handle 0.0.0.0:port binding #26

merged 2 commits into from
Jun 12, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 12, 2017

No description provided.

@fengmk2 fengmk2 added the bug label Jun 12, 2017
@xudafeng xudafeng self-requested a review June 12, 2017 04:18
@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #26 into master will decrease coverage by 1.5%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   94.23%   92.72%   -1.51%     
==========================================
  Files           2        2              
  Lines          52       55       +3     
==========================================
+ Hits           49       51       +2     
- Misses          3        4       +1
Impacted Files Coverage Δ
lib/detect-port.js 92.59% <85.71%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9e127...c1ee961. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants