Skip to content

Commit b3bcf4b

Browse files
authored
Update expected failures in pytest suite. (huggingface#574)
1 parent 6049f86 commit b3bcf4b

File tree

2 files changed

+10
-76
lines changed

2 files changed

+10
-76
lines changed

tank/all_models.csv

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
resnet50,mhlo,tf,1e-02,1e-3,default
2-
albert-base-v2,mhlo,tf,1e-02,1e-3,default
1+
resnet50,mhlo,tf,1e-2,1e-3,default
2+
albert-base-v2,mhlo,tf,1e-2,1e-2,default
33
roberta-base,mhlo,tf,1e-02,1e-3,default
44
bert-base-uncased,mhlo,tf,1e-2,1e-3,default
55
camembert-base,mhlo,tf,1e-2,1e-3,default
@@ -13,19 +13,18 @@ google/vit-base-patch16-224,mhlo,tf,1e-2,1e-3,tf_vit
1313
hf-internal-testing/tiny-random-flaubert,mhlo,tf,1e-2,1e-3,default
1414
microsoft/MiniLM-L12-H384-uncased,mhlo,tf,1e-2,1e-3,tf_hf
1515
microsoft/layoutlm-base-uncased,mhlo,tf,1e-2,1e-3,default
16-
microsoft/mpnet-base,mhlo,tf,1e-2,1e-3,default
16+
microsoft/mpnet-base,mhlo,tf,1e-2,1e-2,default
1717
albert-base-v2,linalg,torch,1e-2,1e-3,default
1818
alexnet,linalg,torch,1e-2,1e-3,default
1919
bert-base-cased,linalg,torch,1e-2,1e-3,default
2020
bert-base-uncased,linalg,torch,1e-2,1e-3,default
21-
distilbert-base-uncased,linalg,torch,1e-2,1e-3,default
2221
facebook/deit-small-distilled-patch16-224,linalg,torch,1e-2,1e-3,default
2322
google/vit-base-patch16-224,linalg,torch,1e-2,1e-3,default
2423
microsoft/beit-base-patch16-224-pt22k-ft22k,linalg,torch,1e-2,1e-3,default
2524
microsoft/MiniLM-L12-H384-uncased,linalg,torch,1e-2,1e-3,default
2625
microsoft/resnet-50,linalg,torch,1e-2,1e-3,default
2726
google/mobilebert-uncased,linalg,torch,1e-2,1e-3,default
28-
mobilenet_v3_small,linalg,torch,1e-2,1e-3,default
27+
mobilenet_v3_small,linalg,torch,1e-1,1e-2,default
2928
nvidia/mit-b0,linalg,torch,1e-2,1e-3,default
3029
resnet101,linalg,torch,1e-2,1e-3,default
3130
resnet18,linalg,torch,1e-2,1e-3,default

tank/test_models.py

Lines changed: 6 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -266,19 +266,14 @@ def test_module(self, dynamic, device, config):
266266
"update_tank"
267267
)
268268
self.module_tester.tank_url = self.pytestconfig.getoption("tank_url")
269-
if (
270-
config["model_name"] == "distilbert-base-uncased"
271-
and config["framework"] == "torch"
272-
):
273-
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/354")
274-
if config["model_name"] == "facebook/convnext-tiny-224" and device in [
275-
"cuda",
276-
"cpu",
269+
if config["model_name"] == "efficientnet-v2-s" and device in [
270+
"metal",
271+
"vulkan",
277272
]:
278-
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/311")
273+
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/575")
279274
if config[
280275
"model_name"
281-
] == "google/vit-base-patch16-224" and device in ["cuda", "cpu"]:
276+
] == "google/vit-base-patch16-224" and device in ["cuda"]:
282277
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/311")
283278
if config["model_name"] == "resnet50" and device in [
284279
"metal",
@@ -289,8 +284,6 @@ def test_module(self, dynamic, device, config):
289284
pytest.xfail(
290285
reason="M2: Assert Error & M1: CompilerToolError"
291286
)
292-
if config["model_name"] == "google/rembert":
293-
pytest.skip(reason="Model too large to convert.")
294287
if config[
295288
"model_name"
296289
] == "dbmdz/convbert-base-turkish-cased" and device in [
@@ -301,7 +294,6 @@ def test_module(self, dynamic, device, config):
301294
reason="Issue: https://github.com/iree-org/iree/issues/9971"
302295
)
303296
if config["model_name"] == "facebook/convnext-tiny-224" and device in [
304-
"cpu",
305297
"cuda",
306298
"metal",
307299
"vulkan",
@@ -310,21 +302,13 @@ def test_module(self, dynamic, device, config):
310302
reason="https://github.com/nod-ai/SHARK/issues/311, https://github.com/nod-ai/SHARK/issues/342"
311303
)
312304
if config["model_name"] == "funnel-transformer/small" and device in [
313-
"cpu",
314305
"cuda",
315306
"metal",
316307
"vulkan",
317308
]:
318309
pytest.xfail(
319310
reason="failing in the iree-compiler passes, see https://github.com/nod-ai/SHARK/issues/201"
320311
)
321-
if (
322-
config["model_name"] == "google/vit-base-patch16-224"
323-
and device == "cuda"
324-
):
325-
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/311")
326-
if config["model_name"] == "microsoft/mpnet-base":
327-
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/203")
328312
if config["model_name"] == "nvidia/mit-b0":
329313
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/343")
330314
if (
@@ -335,12 +319,6 @@ def test_module(self, dynamic, device, config):
335319
pytest.xfail(
336320
reason="Numerics issues -- https://github.com/nod-ai/SHARK/issues/344"
337321
)
338-
if (
339-
config["model_name"] == "google/mobilebert-uncased"
340-
and device == "cpu"
341-
and config["framework"] == "tf"
342-
):
343-
pytest.xfail(reason="Fails during iree-compile.")
344322
if (
345323
config["model_name"] == "facebook/deit-small-distilled-patch16-224"
346324
and device == "cuda"
@@ -355,7 +333,6 @@ def test_module(self, dynamic, device, config):
355333
):
356334
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/390")
357335
if config["model_name"] == "squeezenet1_0" and device in [
358-
"cpu",
359336
"metal",
360337
"vulkan",
361338
]:
@@ -398,11 +375,6 @@ def test_module(self, dynamic, device, config):
398375
"microsoft/resnet-50",
399376
] and device in ["metal", "vulkan"]:
400377
pytest.xfail(reason="Vulkan Numerical Error (mostly conv)")
401-
if config["model_name"] == "mobilenet_v3_small" and device in [
402-
"cuda",
403-
"cpu",
404-
]:
405-
pytest.xfail(reason="https://github.com/nod-ai/SHARK/issues/424")
406378
if config[
407379
"model_name"
408380
] == "dbmdz/convbert-base-turkish-cased" and device in ["cuda", "cpu"]:
@@ -429,44 +401,6 @@ def test_module(self, dynamic, device, config):
429401
pytest.xfail(
430402
reason="Numerics issues: https://github.com/nod-ai/SHARK/issues/476"
431403
)
432-
if (
433-
config["model_name"] == "microsoft/MiniLM-L12-H384-uncased"
434-
and device == "cpu"
435-
):
436-
pytest.xfail(reason="Fails during iree-compile")
437-
if (
438-
config["model_name"] in ["albert-base-v2"]
439-
and device == "cpu"
440-
and dynamic == False
441-
and config["framework"] == "tf"
442-
):
443-
pytest.xfail(
444-
reason="Numerics issues: https://github.com/nod-ai/SHARK/issues/489"
445-
)
446-
if (
447-
config["model_name"]
448-
in [
449-
"microsoft/resnet-50",
450-
"alexnet",
451-
"resnet101",
452-
"resnet18",
453-
"resnet50",
454-
"wide_resnet50_2",
455-
]
456-
and device
457-
in [
458-
"cpu",
459-
"cuda",
460-
]
461-
and config["framework"] == "torch"
462-
):
463-
pytest.xfail(
464-
reason="tensor dimension issue: https://github.com/nod-ai/SHARK/issues/511"
465-
)
466-
if config["model_name"] == "squeezenet1_0" and device == "cuda":
467-
pytest.xfail(
468-
reason="tensor dimension issue: https://github.com/nod-ai/SHARK/issues/511"
469-
)
470404
if config["framework"] == "tf" and dynamic == True:
471405
pytest.skip(
472406
reason="Dynamic shapes not supported for this framework."
@@ -488,3 +422,4 @@ def test_module(self, dynamic, device, config):
488422
)
489423
p.start()
490424
p.join()
425+
assert not p.exitcode

0 commit comments

Comments
 (0)