Skip to content

Have the scan() API return an object of results. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nkolban opened this issue Aug 7, 2017 · 2 comments
Closed

Have the scan() API return an object of results. #30

nkolban opened this issue Aug 7, 2017 · 2 comments
Assignees

Comments

@nkolban
Copy link
Owner

nkolban commented Aug 7, 2017

At present, we are returning a std::vector() from scan(). While this is "ok", we can do better by returning an object that is a container of results ... eg.

BLEScanResults
-> getCount() -> Number of results
-> getResult(i) -> Get the ith result

This would provide a nice encaspulation. However, the most important reason (to me) is that it would elminate the need to expose a piece of std::c++ in an Arduino environment.

@nkolban nkolban self-assigned this Aug 7, 2017
@nkolban
Copy link
Owner Author

nkolban commented Aug 7, 2017

Starting work

nkolban added a commit that referenced this issue Aug 8, 2017
@nkolban
Copy link
Owner Author

nkolban commented Aug 8, 2017

Code changes made and tested.

@nkolban nkolban closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant