Skip to content

Separate OpenBSD and FreeBSD in fcntl.rs #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2017
Merged

Separate OpenBSD and FreeBSD in fcntl.rs #622

merged 1 commit into from
Jun 20, 2017

Conversation

equal-l2
Copy link
Contributor

@equal-l2 equal-l2 commented Jun 19, 2017 •
edited
Loading

Those two OSes cannot be together since the following FreeBSD flags aren't available on OpenBSD.

  • O_DIRECT
  • O_EXEC
  • O_TTY_INIT

@equal-l2 equal-l2 changed the title Separate OpenBSD and FreeBSD in fcntl.h Separate OpenBSD and FreeBSD in fcntl.rs Jun 19, 2017
@asomers
Copy link
Member

asomers commented Jun 19, 2017

LGTM. Thanks for the fix!

bors r+

bors bot added a commit that referenced this pull request Jun 19, 2017
@bors
Merge #622
ccdcee7 
622: Separate OpenBSD and FreeBSD in fcntl.rs r=asomers

Those two OSes cannot be together since the following FreeBSD flags aren't available on OpenBSD.
- `O_DIRECT`
- `O_EXEC`
- `O_TTY_INIT`
@bors
Copy link
Contributor

bors bot commented Jun 19, 2017

Timed out

@notriddle
Copy link
Contributor

Going to re-r+ this one, too?

@asomers
Copy link
Member

asomers commented Jun 20, 2017

Yeah.

bors r+

bors bot added a commit that referenced this pull request Jun 20, 2017
@bors
Merge #622
96f26db 
622: Separate OpenBSD and FreeBSD in fcntl.rs r=asomers

Those two OSes cannot be together since the following FreeBSD flags aren't available on OpenBSD.
- `O_DIRECT`
- `O_EXEC`
- `O_TTY_INIT`
@bors
Copy link
Contributor

bors bot commented Jun 20, 2017

Build succeeded

@bors bors bot merged commit c77d505 into nix-rust:master Jun 20, 2017
@equal-l2 equal-l2 deleted the remove-unavailable-flags branch June 20, 2017 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@equal-l2 @asomers @notriddle