Skip to content

Support powerpc64 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2017
Merged

Support powerpc64 #599

merged 3 commits into from
Jun 20, 2017

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented May 2, 2017

The test_ioctl values are computed using ioctl-test.c

@Susurrus
Copy link
Contributor

This is blocking on #590. Once we're using cross/trust to do cross-platform testing, we can enable powerpc64. That should be part of this PR once we merge #590.

@Susurrus
Copy link
Contributor

Now that #590 is merged and we're using cross, let's go ahead and add PowerPC64 to the test framework as well. Please rebase these commits on top of the latest HEAD on top of adding powerpc64 to the Travis CI tests.

@Susurrus
Copy link
Contributor

@lu-zero Are you still interested in getting this merged? Just wanted to check in since it's been a while on this.

@lu-zero
Copy link
Contributor Author

lu-zero commented Jun 19, 2017

I had been busy, if you can point me to the test harness I can have a look.

lu-zero added 2 commits June 19, 2017 20:10
The test_ioctl values are computed using ioctl-test.c
@Susurrus
Copy link
Contributor

@lu-zero Was gonna point you to the right spot, but it looks like you found it! This is close to ready, but could you update the README adding powerpc64/64le to the Tier1 list? And also squash this into one commit?

Once that's done, this is RTM.

@lu-zero
Copy link
Contributor Author

lu-zero commented Jun 19, 2017

great :) I was afraid I was missing something, let me know if the update is fine. (changed to keep the lines grouped)

@Susurrus
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jun 20, 2017
599: Support powerpc64 r=Susurrus

The test_ioctl values are computed using ioctl-test.c
@bors
Copy link
Contributor

bors bot commented Jun 20, 2017

@bors bors bot merged commit a5130ac into nix-rust:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants