Raise the bors timeout to four hours #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @notriddle! When changing arbitrary values to other arbitrary values I'm a big fan of excessive documentation. And since I don't even know the reasoning for why 4 hours was chosen, can you elaborate both in the |
bors's timeout should always be twice a long as the test suite takes. This is to allow Travis to fast-fail a test; if one of the builders immediately reports a failure, then bors will move on to the next batch, leaving the slower builders to work through the already-doomed run and the next one. At the time this was written, nix's test suite took about an hour to run. The timeout was raised to four hours, instead of two, to give nix room to grow and time for delays on Travis's end.
|
I added a comment about the matter to bors.toml |
|
Oh yeah, love it! Thanks, @notriddle! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout is, by default, one hour.
nixbuilds take about that long,sometimes longer, sometimes shorter, making builds flaky.