Skip to content

docs: doc that signal-unsafe fns can be called after execve #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

SteveLauC
Copy link
Member

What does this PR do

Resolves the issue reported in this comment

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC SteveLauC marked this pull request as ready for review February 2, 2025 09:27
@SteveLauC SteveLauC enabled auto-merge February 2, 2025 09:27
@interacsion
Copy link

I believe this needs to be added to https://docs.rs/nix/latest/nix/pty/fn.forkpty.html as well

@SteveLauC
Copy link
Member Author

I believe this needs to be added to https://docs.rs/nix/latest/nix/pty/fn.forkpty.html as well

Right, sorry for missing that🫠, thanks for catching it!

@SteveLauC SteveLauC force-pushed the docs/fork_signal_safety branch from 3d64d41 to d01b98d Compare February 2, 2025 10:25
@SteveLauC SteveLauC force-pushed the docs/fork_signal_safety branch from d01b98d to f11b493 Compare February 2, 2025 11:09
@SteveLauC SteveLauC added this pull request to the merge queue Feb 2, 2025
Merged via the queue into nix-rust:master with commit c2a7b25 Feb 2, 2025
37 checks passed
@SteveLauC SteveLauC deleted the docs/fork_signal_safety branch February 2, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants