Skip to content

About *at functions #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oblique opened this issue Dec 12, 2018 · 3 comments
Open

About *at functions #998

oblique opened this issue Dec 12, 2018 · 3 comments

Comments

@oblique
Copy link
Contributor

oblique commented Dec 12, 2018

I notice that a lot of *at functions are missing, however there are some unmerged PR which are also closed (see #562, #605, #751).

At #751 @Susurrus suggested AbsPath(&P), RelCurDir(&P), and RelTo(&P, &RawFd), however I believe it can be simplified to: Path(&P) and RelTo(RawFd, &P).

I'm willing to start adding *at functions, but I want to know if you agree with my simplified suggestion.
@Susurrus
Copy link
Contributor

Susurrus commented Dec 13, 2018 •
edited
Loading

Why do you get rid of RelCurDir? How is it replaced by Path?

@oblique
Copy link
Contributor Author

oblique commented Dec 13, 2018 •
edited
Loading

I want to get rid of AbsPath, not RelCurDir. User defines absolute path by having / at the beginning, otherwise it is relative. So Path handles both cases. I don't see what AbsPath can give us more.

@oblique
Copy link
Contributor Author

oblique commented Jan 7, 2019

How should I proceed on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oblique @Susurrus