Skip to content

Should we add a rust-toolchain.toml to pin the toolchain to the MSRV #2160

Closed
@SteveLauC

Description

@SteveLauC

This

You'll have to raise MSRV to 1.69.0 to use CStr::from_byte_with_nul.

makes me realize that our contributors are probably not using the same toolchain as our CI environment, which may confuse them a little bit when encountering CI failures that didn't happen on their local machine.

If we pin Nix's toolchain to the MSRC and keep it in sync with our CI, our contributors can find the issue early and fix it, which would make our contributing experience better

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions