use std::env::temp_dir() to retrieve the temp directory in test_mkstemp

Author: ndusart

test/test_unistd.rs

@@ -64,27 +64,27 @@ fn test_wait() {
 
 #[test]
 fn test_mkstemp() {
-    #[cfg(target_os = "android")]
-    let tmp = "/data/local/tmp/";
-    #[cfg(not(target_os = "android"))]
-    let tmp = "/tmp/";
+    use std::env;
 
-    let result = mkstemp((tmp.to_owned() + "nix_tempfile.XXXXXX").as_str());
+    let mut path = env::temp_dir();
+    path.push("nix_tempfile.XXXXXX");
+
+    let result = mkstemp(&path);
     match result {
         Ok((fd, path)) => {
             close(fd).unwrap();
             unlink(path.as_path()).unwrap();
         },
         Err(e) => panic!("mkstemp failed: {}", e)
     }
+}
 
-    let result = mkstemp(tmp);
-    match result {
-        Ok(_) => {
-            panic!("mkstemp succeeded even though it should fail (provided a directory)");
-        },
-        Err(_) => {}
-    }
+#[test]
+fn test_mkstemp_directory() {
+    use std::env;
+
+    // mkstemp should fail if a directory is given
+    assert!(mkstemp(&env::temp_dir()).is_err());
 }
 
 #[test]