-
Notifications
You must be signed in to change notification settings - Fork 532
MRG: TOPUP update #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: TOPUP update #794
Conversation
satra
commented
Feb 10, 2014
- allows specifying different phase encode directions for individual volumes
- simplifies output naming
- clarifies mandatory requirements
- update workflows that depend on these interfaces
* master: fix: moving save from numpy to pickle install ordereddict for py26 fix: moving save from numpy to pickle install ordereddict for py26 fix: update conda in environment fix: parenthesis fixes dbg: anaconda to miniconda update dbg: conda update fix: update conda ENH: Large SGE jobs were overloading on qstat
@arnaudbore - could you test this branch out? it seems to be fine with the things i am running. |
Hi Satra, I still have the error message. I'm working with the master I guess. How can I be sure of the version that I'm using ? Arnaud |
assuming you have no local changes in the nipype repo you can do this:
|
I'm sorry satra it doesn't work well. I still have the error message Look what I'm doing: git clone https://github.com/nipy/nipype.git I looked into /usr/local/lib/python2.7/dist-packages/nipype and the files that you changed were actually changed so I think I've done it right but I'm not familiar with git so maybe I'm forgetting something... Thank you for your help. |
Hi there, I'm able to help with this by now. What is the status of this right now?, referring to this initial guidelines:
|
Hi, When I run the topup function with a specific output name it raises an error but different from what we had so far so I think satra fixed the output naming. If I use a differect dirrectory than the current one for the output it still raises me an error because it's looking for the output file in the current directory. Thank you |
@oesteban and @arnaudbore - this request is ready for a good review. since topup takes a long time to run, it would be nice to have a minimal regression test for this. anyone has a low resolution dataset to test this with? |
Yes, we could (with permission of @ecaruyer) include a low-res version of Phantomas / paper (ISMRM14), to test topup and also any other dwi-derived interface/workflow. I've used it in this paper (ISBI14), so the test is almost written already (that paper is actually the reason why I implemented that scaffold of an interface for topup). |
Hi all, Sure, the tool is here to be shared! If you could simply somewhere keep a ref to the phantomas project home on github https://github.com/ecaruyer/phantomas or on my website http://www.emmanuelcaruyer.com/phantomas.php |
@oesteban - i'll merge this and open a different pr for regression tests for nipype. |
Sounds good :) |
I wrote an example that uses TOPUP here: https://github.com/oesteban/nipype/blob/enh/NewEPIArtifactCorrections/examples/dmri_preprocessing.py And it works nicely as regards TOPUP (motion correction is not very good due to FLIRT limitations, though) |
* TOPUP: regarding nipy#794, nipy#796 I've cleaned up the docstring and implemented the three arguments that were still missing. The problem is that TOPUP admits one or more values for them, so the implementation of all the traits should be updated. * Eddy: the implementation of @JensNRAD seems to work out, I reviewed the docstring. Close nipy#769. * Added deprecation notices and minor fixes.