Fix for Eddy-Wrapper does not work properly #769 #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -316,7 +316,8 @@ class EddyInputSpec( FSLCommandInputSpec ): | |||
|
|
|||
|
|
|||
| session = File(exists=True, desc='File containing session indices for all volumes in --imain', argstr='--session=%s' ) | |||
| in_topup = File(exists=True, desc='Base name for output files from topup', argstr='--topup=%s' ) | |||
| in_topup = traits.Str('topup_basename', desc='Base name for output files from topup', | |||
| argstr='--topup=%s', usedefault=False) | |||
There was a problem hiding this comment.
@JensNRAD - i believe chris' suggestion was to break this into two inputs
in_topup_fieldcoef = File(exists=True, argstr="--topup=%s", requires=['in_topup_movpar'], ...) and
in_topup_movpar = File(exists=True, requires=['in_topup_fieldcoef'], ...) note the lack of argstr here.
and then overwrite format_args
if name == 'in_topup_fieldcoeff`:
return spec.argstr % value.split('_fieldcoef')[0]
|
@satra Hi I changed it according to your suggestion. |
… directory when running in a workflow
a workflow fix, auto tests and some PEP8 changes
|
@JensNRAD - do these fixes work for you? i actually did them blindly without testing. |
|
As far as I can tell the only difference you introduced is the copyfile=False setting (and the adjusted test file), right? It still works, as before, generating this warning |
|
that warning is fine - it's because of the |
satra
added a commit
that referenced
this pull request
Feb 5, 2014
Fix for Eddy-Wrapper does not work properly #769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.