Skip to content

fix: support for stricter checking with ants bsplinesyn #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2014

Conversation

satra
Copy link
Member

@satra satra commented Jan 15, 2014

@hjmjohnson - does this seem reasonable?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8c70c51 on satra:fix/antsbspline into 0928a3a on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fda3eda on satra:fix/antsbspline into 0928a3a on nipy:master.

@hjmjohnson
Copy link
Contributor

@satra Can this be merged? I thought this was ready for merging a few days ago.

satra added a commit that referenced this pull request Jan 17, 2014
fix: support for stricter checking with ants bsplinesyn
@satra satra merged commit cf81228 into nipy:master Jan 17, 2014
@roelant001
Copy link

I'm still encountering this issue. I've installed the most recent version from github. Am I doing something wrong or is this "bug" still persisting? When manually removing the .0's from the command and running it, it runs successfully. Any suggestions?

relevant settings:

reg.inputs.transforms = ['Translation','Rigid', 'Affine', 'SyN', 'BSplineSyN']
reg.inputs.transform_parameters = [(0.1,),(0.1,), (0.1,), (0.2, 3.0, 0.0),(0.25,25,0)]

Description: itk::ERROR: CommandLineParser(0x183c7b0): ERROR: Parse error occured during command line argument processing
ERROR: Unable to convert '25.0' to type 'j' as unsigned int

@ntustison
Copy link

I accommodated this issue on the ANTs side with this commit

ANTsX/ANTs@05ed1ba

@satra
Copy link
Member Author

satra commented Aug 6, 2015

@roelant001 - BSplineSyn needs 4 parameters, not 3, so the three parameter version is being cast to all floats.

see: https://github.com/nipy/nipype/blob/master/nipype/interfaces/ants/registration.py#L316

@roelant001
Copy link

Thanks!! @ntustison and @satra for this (very simple) explanation and solution.
I assumed the 4th parameter (splineOrder) would default when left empty. Assumptions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants