Skip to content

Test and sorting for DataFinder #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2014
Merged

Conversation

chrisgorgo
Copy link
Member

No description provided.

@@ -17,6 +17,8 @@ def atoi(text):
return int(text) if text.isdigit() else text

def natural_keys(text):
if isinstance(text,tuple):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be a space after , for PEP8?

@yarikoptic
Copy link
Member

today is not my day I guess or am I doing smth wrong

$> git show
commit 62b9c5fb044b674bb1b2c53c83c238c3a6c1370b
Merge: 0db2d30 bd5e4fe
Author: Chris Filo Gorgolewski <[email protected]>
Date:   Wed Jan 8 08:36:05 2014 -0800

    Merge bd5e4fee5c3768669837f33d8ea2fadfccaff222 into 0db2d30399870d77b01fbc1c75ce5ed90a5d4a29

$> nosetests -s -v nipype/interfaces/tests/test_io.py:test_datafinder_copydir
/home/yoh/deb/gits/pkg-exppsy/nipype/nipype/__init__.py:57: UserWarning: Running the tests from the install directory may trigger some failures
  warnings.warn('Running the tests from the install directory may '
test_io.test_datafinder_copydir('findmetoo.txt', 'findme.txt') ... FAIL
test_io.test_datafinder_copydir('findme.txt', 'findmetoo.txt') ... FAIL
test_io.test_datafinder_copydir(['findme', 'findmetoo'], ['findme', 'findmetoo']) ... ok

======================================================================
FAIL: test_io.test_datafinder_copydir('findmetoo.txt', 'findme.txt')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/lib/pymodules/python2.7/numpy/testing/utils.py", line 314, in assert_equal
    raise AssertionError(msg)
AssertionError: 
Items are not equal:
 ACTUAL: 'findmetoo.txt'
 DESIRED: 'findme.txt'

======================================================================
FAIL: test_io.test_datafinder_copydir('findme.txt', 'findmetoo.txt')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/lib/pymodules/python2.7/numpy/testing/utils.py", line 314, in assert_equal
    raise AssertionError(msg)
AssertionError: 
Items are not equal:
 ACTUAL: 'findme.txt'
 DESIRED: 'findmetoo.txt'

----------------------------------------------------------------------
Ran 3 tests in 0.008s

FAILED (failures=2)

@yarikoptic
Copy link
Member

passes for me now -- are we friends again? ;)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) when pulling 63eaeb5 on chrisfilo:enh/datafinder_test into 8b1d21c on nipy:master.

@satra
Copy link
Member

satra commented Jan 8, 2014

since we are in the mode of fixing, can we ensure full coverage?

https://coveralls.io/files/113167197#L724

moloney and others added 2 commits January 13, 2014 14:25
TST+BF: Improve DataFinder tests, fix issue with unpack_single and sorti...
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ce0ff04 on chrisfilo:enh/datafinder_test into 8b1d21c on nipy:master.

@satra
Copy link
Member

satra commented Jan 15, 2014

@moloney thanks for the test coverage

other folks: is this ready for merge?

satra added a commit that referenced this pull request Jan 23, 2014
@satra satra merged commit 8341801 into nipy:master Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants