-
Notifications
You must be signed in to change notification settings - Fork 532
[DOC] Update SelectFiles docstring to match actual behavior #3041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
>>> dg.inputs.run = [2, 4] | ||
>>> dg.inputs.run = [10, 11] | ||
|
||
would match f0.nii or f1.nii, not f10.nii or f11.nii. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I think I misunderstood #2712. I interpreted it as you saying that
templates["epi"] = "{subject_id}/func/f[10].nii"
would produce the result you describe. For the code above, I would have expected to match f10.nii
and f11.nii
.
Possibly @mwaskom can clarify whether this was the intended behavior, though it's been a long time since #623.
Co-Authored-By: Oscar Esteban <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
==========================================
+ Coverage 67.53% 70.18% +2.64%
==========================================
Files 344 345 +1
Lines 44093 66874 +22781
Branches 5555 10123 +4568
==========================================
+ Hits 29779 46933 +17154
- Misses 13560 18604 +5044
- Partials 754 1337 +583
Continue to review full report at Codecov.
|
Looks like we're not going to get clarification on intent, and making the docstring match historical behavior seems safer than fixing a potentially load-bearing bug. |
Summary
Fixes #2712 through clarification.
List of changes proposed in this PR (pull-request)
Acknowledgment