Skip to content

FIX: Import mmap into inner function for all_fsl_pipeline #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2017

Conversation

gjcooper
Copy link
Contributor

Rationale:

Similar to pull request #1831 (and follow up to #1796) there was a function level import for NUMPY_MMAP that was missing, causing a NameError

Changes proposed in this pull request

  • import NUMPY_MMAP into _gen_index [inner function of all_fsl_pipeline]

@codecov-io
Copy link

Codecov Report

Merging #2058 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
- Coverage   72.17%   72.17%   -0.01%     
==========================================
  Files        1136     1136              
  Lines       57146    57147       +1     
  Branches     8185     8185              
==========================================
  Hits        41243    41243              
- Misses      14616    14617       +1     
  Partials     1287     1287
Flag Coverage Δ
#smoketests 72.17% <0%> (-0.01%) ⬇️
#unittests 69.78% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/workflows/dmri/fsl/artifacts.py 80.88% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603f424...fdee60e. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 30, 2017

Codecov Report

Merging #2058 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
- Coverage   72.17%   72.17%   -0.01%     
==========================================
  Files        1136     1136              
  Lines       57146    57147       +1     
  Branches     8185     8185              
==========================================
  Hits        41243    41243              
- Misses      14616    14617       +1     
  Partials     1287     1287
Flag Coverage Δ
#smoketests 72.17% <0%> (-0.01%) ⬇️
#unittests 69.78% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/workflows/dmri/fsl/artifacts.py 80.88% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603f424...fdee60e. Read the comment docs.

@oesteban oesteban merged commit a61e455 into nipy:master May 30, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants