[FIX] Several fixes related to unicode literals #1656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
changed the title
Current coverage is 70.96% (diff: 69.81%)@@ master #1656 diff @@
==========================================
Files 1025 1025
Lines 51416 51436 +20
Methods 0 0
Messages 0 0
Branches 7286 7294 +8
==========================================
+ Hits 36488 36502 +14
- Misses 13845 13849 +4
- Partials 1083 1085 +2
|
oesteban
changed the title
oesteban
commented
Sep 23, 2016
| @@ -329,6 +330,8 @@ def _get_valid_pathstr(pathstr): | |||
| Removes: [][ (){}?:<>#!|"';] | |||
| Replaces: ',' -> '.' | |||
| """ | |||
| if not isinstance(pathstr, (str, bytes)): | |||
| pathstr = to_str(pathstr) | |||
There was a problem hiding this comment.
@satra, pathstr was converted to string using the __str__ member. However, for lists, tuples, dict, etc, they fall back to repr. After adding unicode_literals everywere, repr('some string') is u'some string' with the u (only python 2). This u will be there after the pathstr is fixed for not valid characters.
|
@satra @chrisfilo this is ready and very much needed, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repr()and re-definitions of__repr__have been revised(again, this is related to [BUG] Parameterization in python 2 contains 'u' prefixes in parameter names #1644, python 2.7 string issue in plugins #1621, etc).