Fix #1584 color graphing to loop through blue, red, green. #1585
Conversation
|
Changes Unknown when pulling cfcc576 on ashgillman:allow_arbitrary_depth_graphing into * on nipy:master*. |
ashgillman
force-pushed
the
allow_arbitrary_depth_graphing
branch
from
cfcc576 to
58fc79d
Compare
|
I realised this PR was very unclear, so I have added failing tests demonstrating the issue which now pass. |
|
Whoops, looks like CI test don't have dot. Is there a way I can test producing the dot file without running graphviz to produce a png? |
|
@ashgillman - apparently, the problem only affects travis. It makes sense since I think I included graphviz in the docker image (which is what circleci uses). You'll need to install graphviz, in the .travis.yml file. |
Current coverage is 71.02% (diff: 85.96%)@@ master #1585 diff @@
==========================================
Files 1030 1030
Lines 51764 51818 +54
Methods 0 0
Messages 0 0
Branches 7327 7332 +5
==========================================
+ Hits 36628 36806 +178
+ Misses 14045 13890 -155
- Partials 1091 1122 +31
|
| @@ -33,7 +33,7 @@ install: | |||
| conda config --add channels conda-forge && | |||
| conda update --yes conda && | |||
| conda update --all -y python=$TRAVIS_PYTHON_VERSION && | |||
| conda install -y nipype && | |||
| conda install -y nipype graphviz && | |||
There was a problem hiding this comment.
I think that should go here: https://github.com/ashgillman/nipype/blob/4c3a232b5d70da3638ff54dea173bcf3adf55acb/.travis.yml#L22 as an apt package.
There was a problem hiding this comment.
Ah, yes that would make more sense wouldn't it
|
Is the remaining error due to my code or a run time thing? I can't really tell |
|
I have restarted the build hopefully the error will go away. We are working on a fix. |
|
Looks to have times out for Py27 (but not Py35) at test Not sure if this test is problematic or whether that test just happened to be running during the timeout |
|
Also I don't know if the Travis has rerun since I updated travis.yml |
suggested to Fix #1584
Colors now cycle, yellow for top-level, then B, R, G, B, R, G...