20150804 an ts float test #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A newer version of ANTs has a command line feature added that allows for more optimized processing in multi-stage registrations. ENH: Added new state saving interface to ANTs In order to improve registration efficiency, it is important that we can save and restore the state of a registration so taht continuation may occur from a previous state. ENH: Make transform writing mutually exclusive Writing composite or non-composite transforms needs to be mutually exclusive in the new version of ants.
|
@satra @chrisfilo This patch incorporates ideas and discussion from : #1024 More complete testing of command line was also performed. Backwards compatibility is maintained such that if no "float" is specified, it does not show up on the command line. If it is specified, then True maps to 1 and False maps to 0 as required by ANTs. It would be great to finally get this commit incorporated. Now that ITK bugs related to floating point transforms are fixed, using float = True is rapidly becoming the preferred method (not default) for running deformation based registrations. |
| ## NOTE: Even though only 0=False and 1=True are allowed, ants uses integer values instead of booleans | ||
| float = traits.Bool( | ||
| argstr='--float %d', default=False, | ||
| usedefault=False, ## If --float is not specified, do not add it to the command line |
Expose --float option in ants registration. This allows for computations to be done in single precision rather than double precision.
|
@satra All requested changes made and tests pass, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch supersedes: #1024
In this patch, improved testing and backwards compatibility are preserved for the command line.