-
Notifications
You must be signed in to change notification settings - Fork 532
MultiTensor simulator interface #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It'd be nice if @Garyfallidis or @arokem could give this PR a quick look before merging :) |
It seems strange that the main code here is going to live in nipype and not dipy? |
Well - depending on what you mean by 'main', it is. That's the |
return outputs | ||
|
||
|
||
def _compute_voxel(args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know how this usually works in nipype, but it would be good to have clear documentation for what goes into args
. There's lots of them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use args
to make the method 'pickleable' by multiprocessing
@arokem @mwaskom @Garyfallidis I think there are only a couple of features that may be more appropriate in a PR to dipy:
If there's an insterest in dipy of having these two features, I'll be happy to contribute. |
Those both sound interesting. I am curious to hear how much of a gain you got from simulating the isotropic component separately. As pointed out by @Garyfallidis, this is already doable, by passing a set of identical evals, but if there's a substantial gain by doing it separately, it might be worth doing. Concerning your second point, we're planning to have a hangout to discuss parallel processing in dipy, and we'd be happy to have your input on that, see link to scheduling on dipy/dipy#631 |
@arokem I'll see to participate in the parallel processing chat. However I'm far from an expert. I just know how to use @chrisfilo @satra: what do you think about merging this as is now, and updating this interface when the features under discussion are added into dipy? |
Conflicts: CHANGES
@arokem @Garyfallidis I finally integrated the simulation of isotropic compartments using |
pinging to see where this is at. |
I think that with the last merge with master, everything is ready from my side and all the questions were answered :) |
Insert entry in CHANGES for #1085
An interface to simulate diffusion weighted images (DWIs) using the multi-tensor model included in dipy in a ball-and-stick -like fashion:
Diffusivity of the isotropic compartments and the single-fiber tensor are taken from: