-
Notifications
You must be signed in to change notification settings - Fork 532
Codecov submission is not enabled on Travis #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
we decided to remove it from travis and just focus on the circle coverage. there didn't seem to be a way to accumulate coverage across travis + circle. since circle runs tests + workflows it seemed the better place to submit coverage reports from. |
I don't mind either way, but the whole point of CodeCov was to aggregate coverage reports across different CI providers. I'm surprised it didn't work. I don't think it's important enough to split hairs though. |
we won't split hairs, but we should check this out again. |
@chrisfilo - yes, it was I who removed codecov from travis... I remember I did it after talking to @satra , but I don't recall that we concluded that it doesn't work. In fact in the first Pytest PR #1722 I used coverage from Travis and CircleCI. I believe I wasn't sure how exactly CodeCov works and we simply agreed that CircleCI runs all tests from Travis anyway (plus some others), so we might just remove CodeCov from Travis, and then we're sure that the coverage is taken from CircleCI (and not from Travis only), but I might be wrong. |
It used to be, but it disappeared at some point. @djarecka do you know anything about it?
The text was updated successfully, but these errors were encountered: